[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 1/5] vfio/pci: Disable INTx fast path if using split irqchip
From: |
Peter Xu |
Subject: |
[PATCH v4 1/5] vfio/pci: Disable INTx fast path if using split irqchip |
Date: |
Wed, 18 Mar 2020 10:52:00 -0400 |
It's currently broken. Let's use the slow path to at least make it
functional.
Tested-by: Eric Auger <address@hidden>
Reviewed-by: Eric Auger <address@hidden>
Reviewed-by: Alex Williamson <address@hidden>
Acked-by: Alex Williamson <address@hidden>
Signed-off-by: Peter Xu <address@hidden>
---
hw/vfio/pci.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
index 5e75a95129..98e0e0c994 100644
--- a/hw/vfio/pci.c
+++ b/hw/vfio/pci.c
@@ -128,6 +128,18 @@ static void vfio_intx_enable_kvm(VFIOPCIDevice *vdev,
Error **errp)
return;
}
+ if (kvm_irqchip_is_split()) {
+ /*
+ * VFIO INTx is currently not working with split kernel
+ * irqchip for level triggered interrupts. Go the slow path
+ * as long as split is enabled so we can be at least
+ * functional (even with poor performance).
+ *
+ * TODO: Remove this after all things fixed up.
+ */
+ return;
+ }
+
/* Get to a known interrupt state */
qemu_set_fd_handler(irqfd.fd, NULL, NULL, vdev);
vfio_mask_single_irqindex(&vdev->vbasedev, VFIO_PCI_INTX_IRQ_INDEX);
--
2.24.1
- [PATCH v4 0/5] vfio/pci: Fix up breakage against split irqchip and INTx, Peter Xu, 2020/03/18
- [PATCH v4 1/5] vfio/pci: Disable INTx fast path if using split irqchip,
Peter Xu <=
- [PATCH v4 2/5] vfio/pci: Use kvm_irqchip_add_irqfd_notifier_gsi() for irqfds, Peter Xu, 2020/03/18
- [PATCH v4 3/5] KVM: Pass EventNotifier into kvm_irqchip_assign_irqfd, Peter Xu, 2020/03/18
- [PATCH v4 4/5] KVM: Kick resamplefd for split kernel irqchip, Peter Xu, 2020/03/18
- [PATCH v4 5/5] Revert "vfio/pci: Disable INTx fast path if using split irqchip", Peter Xu, 2020/03/18
- Re: [PATCH v4 0/5] vfio/pci: Fix up breakage against split irqchip and INTx, Alex Williamson, 2020/03/31