[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 06/13] machine/memory encryption: Disable mem merge
From: |
Eduardo Habkost |
Subject: |
[PULL 06/13] machine/memory encryption: Disable mem merge |
Date: |
Tue, 17 Mar 2020 21:17:41 -0400 |
From: "Dr. David Alan Gilbert" <address@hidden>
When a host is running with memory encryption, the memory isn't visible
to the host kernel; attempts to merge that memory are futile because
what it's really comparing is encrypted memory, usually encrypted
with different keys.
Automatically turn mem-merge off when memory encryption is specified.
https://bugzilla.redhat.com/show_bug.cgi?id=1796356
Signed-off-by: Dr. David Alan Gilbert <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>
---
hw/core/machine.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/hw/core/machine.c b/hw/core/machine.c
index 9e8c06036f..4778bc6b08 100644
--- a/hw/core/machine.c
+++ b/hw/core/machine.c
@@ -425,6 +425,14 @@ static void machine_set_memory_encryption(Object *obj,
const char *value,
g_free(ms->memory_encryption);
ms->memory_encryption = g_strdup(value);
+
+ /*
+ * With memory encryption, the host can't see the real contents of RAM,
+ * so there's no point in it trying to merge areas.
+ */
+ if (value) {
+ machine_set_mem_merge(obj, false, errp);
+ }
}
static bool machine_get_nvdimm(Object *obj, Error **errp)
--
2.24.1
- [PULL 00/13] x86 and machine queue for 5.0 soft freeze, Eduardo Habkost, 2020/03/17
- [PULL 01/13] target/i386: Add Denverton-v2 (no MPX) CPU model, Eduardo Habkost, 2020/03/17
- [PULL 02/13] target/i386: Add new property note to versioned CPU models, Eduardo Habkost, 2020/03/17
- [PULL 03/13] i386: Add missing cpu feature bits in EPYC model, Eduardo Habkost, 2020/03/17
- [PULL 06/13] machine/memory encryption: Disable mem merge,
Eduardo Habkost <=
- [PULL 05/13] hw/i386: Rename X86CPUTopoInfo structure to X86CPUTopoIDs, Eduardo Habkost, 2020/03/17
- [PULL 08/13] hw/i386: Introduce X86CPUTopoInfo to contain topology info, Eduardo Habkost, 2020/03/17
- [PULL 09/13] hw/i386: Consolidate topology functions, Eduardo Habkost, 2020/03/17
- [PULL 04/13] i386: Add 2nd Generation AMD EPYC processors, Eduardo Habkost, 2020/03/17
- [PULL 11/13] hw/i386: Remove unnecessary initialization in x86_cpu_new, Eduardo Habkost, 2020/03/17
- [PULL 07/13] cpu: Use DeviceClass reset instead of a special CPUClass reset, Eduardo Habkost, 2020/03/17
- [PULL 12/13] hw/i386: Update structures to save the number of nodes per package, Eduardo Habkost, 2020/03/17
- [PULL 10/13] machine: Add SMP Sockets in CpuTopology, Eduardo Habkost, 2020/03/17
- [PULL 13/13] hw/i386: Rename apicid_from_topo_ids to x86_apicid_from_topo_ids, Eduardo Habkost, 2020/03/17