Re: [PATCH] pci: Display PCI IRQ pin in "info pci"

[Eric Blake]

On 3/17/20 2:59 PM, Peter Xu wrote:
> Sometimes it would be good to be able to read the pin number along
> with the IRQ number allocated.  Since we'll dump the IRQ number, no
> reason to not dump the pin information.  For example, the vfio-pci
> device will overwrite the pin with the hardware pin number.  It would
> be nice to know the pin number of one assigned device from QMP/HMP.
>
> CC: Dr. David Alan Gilbert <address@hidden>
> CC: Alex Williamson <address@hidden>
> CC: Michael S. Tsirkin <address@hidden>
> CC: Marcel Apfelbaum <address@hidden>
> CC: Julia Suvorova <address@hidden>
> CC: Markus Armbruster <address@hidden>
> Signed-off-by: Peter Xu <address@hidden>
> ---
>
> This helped me to debug an IRQ sharing issue, so may good to have it
> in master too.

We're right at soft freeze.


> +++ b/qapi/misc.json
> @@ -403,6 +403,8 @@
>   #
>   # @irq: if an IRQ is assigned to the device, the IRQ number
>   #
> +# @irq_pin: the IRQ pin, zero means no IRQ (since 5.1)
> +#

But if we really do want it in 5.0, this needs a tweak.  Does the delay 
hurt?

Naming convention: We prefer 'irq-pin' unless there is a consistency 
issue....

>   # @qdev_id: the device name of the PCI device
>   #
>   # @pci_bridge: if the device is a PCI bridge, the bridge information
> @@ -417,8 +419,8 @@
>   { 'struct': 'PciDeviceInfo',
>     'data': {'bus': 'int', 'slot': 'int', 'function': 'int',
>              'class_info': 'PciDeviceClass', 'id': 'PciDeviceId',
> -           '*irq': 'int', 'qdev_id': 'str', '*pci_bridge': 'PciBridgeInfo',
> -           'regions': ['PciMemoryRegion']} }
> +           '*irq': 'int', 'irq_pin': 'int', 'qdev_id': 'str',
> +           '*pci_bridge': 'PciBridgeInfo', 'regions': ['PciMemoryRegion'] }}

and the pre-existing pci_bridge is indeed the consistency issue.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org