[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 23/30] qcow2: Update L2 bitmap in qcow2_alloc_cluster_link_l2(
From: |
Alberto Garcia |
Subject: |
[PATCH v4 23/30] qcow2: Update L2 bitmap in qcow2_alloc_cluster_link_l2() |
Date: |
Tue, 17 Mar 2020 19:16:20 +0100 |
The L2 bitmap needs to be updated after each write to indicate what
new subclusters are now allocated.
This needs to happen even if the cluster was already allocated and the
L2 entry was otherwise valid.
Signed-off-by: Alberto Garcia <address@hidden>
Reviewed-by: Max Reitz <address@hidden>
---
block/qcow2-cluster.c | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
index ceacd91ea3..dfd8b66958 100644
--- a/block/qcow2-cluster.c
+++ b/block/qcow2-cluster.c
@@ -1006,6 +1006,23 @@ int qcow2_alloc_cluster_link_l2(BlockDriverState *bs,
QCowL2Meta *m)
assert((offset & L2E_OFFSET_MASK) == offset);
set_l2_entry(s, l2_slice, l2_index + i, offset | QCOW_OFLAG_COPIED);
+
+ /* Update bitmap with the subclusters that were just written */
+ if (has_subclusters(s)) {
+ unsigned written_from = m->cow_start.offset;
+ unsigned written_to = m->cow_end.offset + m->cow_end.nb_bytes ?:
+ m->nb_clusters << s->cluster_bits;
+ uint64_t l2_bitmap = get_l2_bitmap(s, l2_slice, l2_index + i);
+ int sc;
+ for (sc = 0; sc < s->subclusters_per_cluster; sc++) {
+ int sc_off = i * s->cluster_size + sc * s->subcluster_size;
+ if (sc_off >= written_from && sc_off < written_to) {
+ l2_bitmap |= QCOW_OFLAG_SUB_ALLOC(sc);
+ l2_bitmap &= ~QCOW_OFLAG_SUB_ZERO(sc);
+ }
+ }
+ set_l2_bitmap(s, l2_slice, l2_index + i, l2_bitmap);
+ }
}
--
2.20.1
- [PATCH v4 05/30] qcow2: Process QCOW2_CLUSTER_ZERO_ALLOC clusters in handle_copied(), (continued)
- [PATCH v4 05/30] qcow2: Process QCOW2_CLUSTER_ZERO_ALLOC clusters in handle_copied(), Alberto Garcia, 2020/03/17
- [PATCH v4 11/30] qcow2: Add l2_entry_size(), Alberto Garcia, 2020/03/17
- [PATCH v4 02/30] qcow2: Convert qcow2_get_cluster_offset() into qcow2_get_host_offset(), Alberto Garcia, 2020/03/17
- [PATCH v4 15/30] qcow2: Replace QCOW2_CLUSTER_* with QCOW2_SUBCLUSTER_*, Alberto Garcia, 2020/03/17
- [PATCH v4 21/30] qcow2: Add subcluster support to check_refcounts_l2(), Alberto Garcia, 2020/03/17
- [PATCH v4 25/30] qcow2: Add subcluster support to handle_alloc_space(), Alberto Garcia, 2020/03/17
- [PATCH v4 04/30] qcow2: Split cluster_needs_cow() out of count_cow_clusters(), Alberto Garcia, 2020/03/17
- [PATCH v4 14/30] qcow2: Add cluster type parameter to qcow2_get_host_offset(), Alberto Garcia, 2020/03/17
- [PATCH v4 20/30] qcow2: Add subcluster support to discard_in_l2_slice(), Alberto Garcia, 2020/03/17
- [PATCH v4 08/30] qcow2: Add dummy has_subclusters() function, Alberto Garcia, 2020/03/17
- [PATCH v4 23/30] qcow2: Update L2 bitmap in qcow2_alloc_cluster_link_l2(),
Alberto Garcia <=
- [PATCH v4 24/30] qcow2: Clear the L2 bitmap when allocating a compressed cluster, Alberto Garcia, 2020/03/17
- [PATCH v4 19/30] qcow2: Add subcluster support to zero_in_l2_slice(), Alberto Garcia, 2020/03/17
- [PATCH v4 26/30] qcow2: Restrict qcow2_co_pwrite_zeroes() to full clusters only, Alberto Garcia, 2020/03/17
- [PATCH v4 09/30] qcow2: Add subcluster-related fields to BDRVQcow2State, Alberto Garcia, 2020/03/17
- [PATCH v4 27/30] qcow2: Assert that expand_zero_clusters_in_l1() does not support subclusters, Alberto Garcia, 2020/03/17
- [PATCH v4 13/30] qcow2: Add QCow2SubclusterType and qcow2_get_subcluster_type(), Alberto Garcia, 2020/03/17
- [PATCH v4 07/30] qcow2: Document the Extended L2 Entries feature, Alberto Garcia, 2020/03/17
- [PATCH v4 01/30] qcow2: Make Qcow2AioTask store the full host offset, Alberto Garcia, 2020/03/17
- [PATCH v4 03/30] qcow2: Add calculate_l2_meta(), Alberto Garcia, 2020/03/17