qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/3] Use &error_abort instead of separate assert()


From: Vladimir Sementsov-Ogievskiy
Subject: Re: [PATCH 1/3] Use &error_abort instead of separate assert()
Date: Tue, 17 Mar 2020 15:21:23 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1

14.03.2020 7:58, Markus Armbruster wrote:
Alexander Bulekov <address@hidden> writes:

On 200313 1805, Markus Armbruster wrote:
Signed-off-by: Markus Armbruster <address@hidden>


index 1a99277d60..aa9eee6ebf 100644
--- a/tests/qtest/fuzz/qos_fuzz.c
+++ b/tests/qtest/fuzz/qos_fuzz.c
@@ -57,8 +57,7 @@ static void qos_set_machines_devices_available(void)
      QList *lst;
      Error *err = NULL;
Can this err declaration be removed? Don't think it's used anywhere
else.

Will do.

with this:

Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>


-    qmp_marshal_query_machines(NULL, &response, &err);
-    assert(!err);
+    qmp_marshal_query_machines(NULL, &response, &error_abort);
      lst = qobject_to(QList, response);
      apply_to_qlist(lst, true);
@@ -70,8 +69,7 @@ static void qos_set_machines_devices_available(void)
      qdict_put_bool(args, "abstract", true);
      qdict_put_obj(req, "arguments", (QObject *) args);
- qmp_marshal_qom_list_types(args, &response, &err);
-    assert(!err);
+    qmp_marshal_qom_list_types(args, &response, &error_abort);
      lst = qobject_to(QList, response);
      apply_to_qlist(lst, false);
      qobject_unref(response);
--
2.21.1

Thanks!

Acked-by: Alexander Bulekov <address@hidden>

Thanks!



--
Best regards,
Vladimir



reply via email to

[Prev in Thread] Current Thread [Next in Thread]