Re: [PATCH v1 21/28] configure: allow user to specify what gdb to use

[Alex Bennée]

Peter Maydell <address@hidden> writes:

> On Mon, 16 Mar 2020 at 18:22, Alex Bennée <address@hidden> wrote:
>>
>> This is useful, especially when testing relatively new gdbstub
>> features that might not be in distro packages yet.
>>
>> Signed-off-by: Alex Bennée <address@hidden>
>> Reviewed-by: Richard Henderson <address@hidden>
>> ---
>>  configure | 9 +++++++++
>>  1 file changed, 9 insertions(+)
>>
>> diff --git a/configure b/configure
>> index eb49bb6680c..6724158fde1 100755
>> --- a/configure
>> +++ b/configure
>> @@ -303,6 +303,7 @@ libs_qga=""
>>  debug_info="yes"
>>  stack_protector=""
>>  use_containers="yes"
>> +gdb_bin=$(command -v "gdb")
>>
>>  if test -e "$source_path/.git"
>>  then
>> @@ -1588,6 +1589,8 @@ for opt do
>>    ;;
>>    --disable-fuzzing) fuzzing=no
>>    ;;
>> +  --with-gdb=*) gdb_bin="$optarg"
>> +  ;;
>>    *)
>>        echo "ERROR: unknown option $opt"
>>        echo "Try '$0 --help' for more information"
>> @@ -1773,6 +1776,7 @@ Advanced options (experts only):
>>    --enable-plugins
>>                             enable plugins via shared library loading
>>    --disable-containers     don't use containers for cross-building
>> +  --with-gdb=GBB-path      gdb to use for gdbstub tests [$gdb_bin]
>
> s/GBB/GDB/. (Also, the only other program we pass to configure
> with "--with-foo=" is git; for make, install, python, sphinx-build,
> smbd, iasl, cc, gcov we just use "--foo=".)

Alright I'll fix that up in the PR.

>
> thanks
> -- PMM


-- 
Alex Bennée