qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Enable strace for TARGET_NR_llseek


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH] Enable strace for TARGET_NR_llseek
Date: Tue, 17 Mar 2020 10:19:34 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0

On 3/16/20 9:52 PM, Taylor Simpson wrote:
linux-user/syscall.c handles the case where TARGET_NR_llseek (one underscore)
is defined and TARGET_NR__llseek (two underscores)
     /* Newer kernel ports have llseek() instead of _llseek() */
     #if defined(TARGET_NR_llseek) && !defined(TARGET_NR__llseek)
     #define TARGET_NR__llseek TARGET_NR_llseek
     #endif

Unfortunately, strace will print "Unknown syscall" in this case.  This patch
fixes that problem.

Signed-off-by: Taylor Simpson <address@hidden>
---
  linux-user/strace.c    | 2 +-
  linux-user/strace.list | 3 +++
  2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/linux-user/strace.c b/linux-user/strace.c
index 4f7130b..4bcc00b 100644
--- a/linux-user/strace.c
+++ b/linux-user/strace.c
@@ -1667,7 +1667,7 @@ print_linkat(const struct syscallname *name,
  }
  #endif
-#ifdef TARGET_NR__llseek
+#ifdef defined(TARGET_NR__llseek) || defined(TARGET_NR_llseek)
  static void
  print__llseek(const struct syscallname *name,
      abi_long arg0, abi_long arg1, abi_long arg2,
diff --git a/linux-user/strace.list b/linux-user/strace.list
index d49a1e9..5a01e95 100644
--- a/linux-user/strace.list
+++ b/linux-user/strace.list
@@ -503,6 +503,9 @@
  #ifdef TARGET_NR__llseek
  { TARGET_NR__llseek, "_llseek" , NULL, print__llseek, NULL },
  #endif
+#ifdef TARGET_NR_llseek
+{ TARGET_NR_llseek, "_llseek" , NULL, print__llseek, NULL },
+#endif
  #ifdef TARGET_NR_lock
  { TARGET_NR_lock, "lock" , NULL, NULL, NULL },
  #endif


Reviewed-by: Philippe Mathieu-Daudé <address@hidden>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]