Re: [PULL 00/61] Misc patches for soft freeze

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PULL 00/61] Misc patches for soft freeze
Message-id: address@hidden
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
cd46cc2 hw/arm: Let devices own the MemoryRegion they create
acefd47 hw/arm: Remove unnecessary memory_region_set_readonly() on ROM alias
f26c6ec hw/ppc/ppc405: Use memory_region_init_rom() with read-only regions
014a7f6 hw/arm/stm32: Use memory_region_init_rom() with read-only regions
37b937c hw/char: Let devices own the MemoryRegion they create
5faaec9 hw/riscv: Let devices own the MemoryRegion they create
32e8210 hw/dma: Let devices own the MemoryRegion they create
41b0949 hw/display: Let devices own the MemoryRegion they create
2440d3d hw/core: Let devices own the MemoryRegion they create
cbb4826 scripts/cocci: Patch to let devices own their MemoryRegions
78397a0 scripts/cocci: Patch to remove unnecessary memory_region_set_readonly()
7105f13 scripts/cocci: Patch to detect potential use of memory_region_init_rom
5e29657 hw/sparc: Use memory_region_init_rom() with read-only regions
3eb227a hw/sh4: Use memory_region_init_rom() with read-only regions
eb09349 hw/riscv: Use memory_region_init_rom() with read-only regions
ed4826e hw/ppc: Use memory_region_init_rom() with read-only regions
b105369 hw/pci-host: Use memory_region_init_rom() with read-only regions
a68500f hw/net: Use memory_region_init_rom() with read-only regions
ed9cd1f hw/m68k: Use memory_region_init_rom() with read-only regions
399ba06 hw/display: Use memory_region_init_rom() with read-only regions
51d745b hw/arm: Use memory_region_init_rom() with read-only regions
933a6c5 scripts/cocci: Patch to replace memory_region_init_{ram, readonly -> 
rom}
4fed855 scripts/cocci: Rename memory-region-{init-ram -> housekeeping}
af2a719 memory: Simplify memory_region_init_rom_nomigrate() to ease review
af1e8ca memory: Correctly return alias region type
420272a lockable: add QemuRecMutex support
7145da7 lockable: add lock guards
773b436 cpus: avoid pause_all_vcpus getting stuck due to race
3c6d277 exec/rom_reset: Free rom data during inmigrate skip
46cca43 Use -isystem for linux-headers dir
5e28455 softmmu/vl.c: Handle '-cpu help' and '-device help' before 'no default 
machine'
cbe6b04 qemu-cpu-models.rst: Document -noTSX, mds-no, taa-no, and tsx-ctrl
fda402f ui/curses: Move arrays to .heap to save 74KiB of .bss
d5573ac ui/curses: Make control_characters[] array const
7c3e49f hw/usb/quirks: Use smaller types to reduce .rodata by 10KiB
c87784b hw/audio/intel-hda: Use memory region alias to reduce .rodata by 4.34MB
cc21b87 hw/audio/fmopl: Move ENV_CURVE to .heap to save 32KiB of .bss
a1ea1d5 Makefile: Let the 'help' target list the tools targets
9ac297a Makefile: Align 'help' target output
b3219e5 WHPX: Use proper synchronization primitives while processing
7feeb33 i386: Fix GCC warning with snprintf when HAX is enabled
1ea8875 qom/object: Use common get/set uint helpers
7e7ce48 ich9: Simplify ich9_lpc_initfn
a5caa86 ich9: fix getter type for sci_int property
65692c6 qom/object: enable setter for uint types
f78a8b0 memory: Fix start offset for bitmap log_clear hook
bbb0d03 tests/docker: Install SASL library to extend code coverage on amd64
0b44062 configure: Fix building with SASL on Windows
59337c0 modules: load modules from versioned /var/run dir
3108fd7 build-sys: do not make qemu-ga link with pixman
4668b2a oslib-posix: initialize mutex and condition variable
374e906 hw/i386/intel_iommu: Fix out-of-bounds access on guest IRT
91ae0b7 MAINTAINERS: Add entry for Guest X86 HAXM CPUs
b75790f WHPX: Use QEMU values for trapped CPUID
6b4d015 WHPX: TSC get and set should be dependent on VM state
31dab17 util: add util function buffer_zero_avx512()
1af2201 configure: add configure option avx512f_opt
c80c8bc misc: Replace zero-length arrays with flexible array member (manual)
cda1965 misc: Replace zero-length arrays with flexible array member (automatic)
c231a41 optionrom/pvh: scan entire RSDP Area
ac0f826 scsi/qemu-pr-helper: Fix out-of-bounds access to trnptid_list[]

=== OUTPUT BEGIN ===
1/61 Checking commit ac0f8263e015 (scsi/qemu-pr-helper: Fix out-of-bounds 
access to trnptid_list[])
2/61 Checking commit c231a414ecc4 (optionrom/pvh: scan entire RSDP Area)
3/61 Checking commit cda196559230 (misc: Replace zero-length arrays with 
flexible array member (automatic))
4/61 Checking commit c80c8bc2cfc5 (misc: Replace zero-length arrays with 
flexible array member (manual))
5/61 Checking commit 1af220199ceb (configure: add configure option avx512f_opt)
6/61 Checking commit 31dab17d3ff5 (util: add util function buffer_zero_avx512())
WARNING: architecture specific defines should be avoided
#43: FILE: util/bufferiszero.c:66:
+#if defined(CONFIG_AVX512F_OPT) || defined(CONFIG_AVX2_OPT) || 
defined(__SSE2__)

WARNING: Block comments use a leading /* on a separate line
#165: FILE: util/bufferiszero.c:304:
+            /* 0xe6:

WARNING: Block comments should align the * on each line
#166: FILE: util/bufferiszero.c:305:
+            /* 0xe6:
+            *  XCR0[7:5] = 111b (OPMASK state, upper 256-bit of ZMM0-ZMM15

total: 0 errors, 3 warnings, 150 lines checked

Patch 6/61 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/61 Checking commit 6b4d015193ca (WHPX: TSC get and set should be dependent on 
VM state)
8/61 Checking commit b75790f183b2 (WHPX: Use QEMU values for trapped CPUID)
9/61 Checking commit 91ae0b7de40d (MAINTAINERS: Add entry for Guest X86 HAXM 
CPUs)
10/61 Checking commit 374e906d0c52 (hw/i386/intel_iommu: Fix out-of-bounds 
access on guest IRT)
11/61 Checking commit 4668b2ab7090 (oslib-posix: initialize mutex and condition 
variable)
ERROR: do not initialise statics to 0 or NULL
#24: FILE: util/oslib-posix.c:469:
+    static gsize initialized = 0;

total: 1 errors, 0 warnings, 17 lines checked

Patch 11/61 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

12/61 Checking commit 3108fd76c8d2 (build-sys: do not make qemu-ga link with 
pixman)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#45: 
rename from contrib/vhost-user-gpu/main.c

total: 0 errors, 1 warnings, 10 lines checked

Patch 12/61 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
13/61 Checking commit 59337c02833d (modules: load modules from versioned 
/var/run dir)
14/61 Checking commit 0b44062a64ae (configure: Fix building with SASL on 
Windows)
15/61 Checking commit bbb0d039a09e (tests/docker: Install SASL library to 
extend code coverage on amd64)
16/61 Checking commit f78a8b071c4c (memory: Fix start offset for bitmap 
log_clear hook)
WARNING: line over 80 characters
#46: FILE: exec.c:1349:
+        mr_offset = (ram_addr_t)(start_page << TARGET_PAGE_BITS) - 
ramblock->offset;

total: 0 errors, 1 warnings, 27 lines checked

Patch 16/61 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/61 Checking commit 65692c604191 (qom/object: enable setter for uint types)
18/61 Checking commit a5caa86f8371 (ich9: fix getter type for sci_int property)
19/61 Checking commit 7e7ce489c4d4 (ich9: Simplify ich9_lpc_initfn)
20/61 Checking commit 1ea88756290f (qom/object: Use common get/set uint helpers)
21/61 Checking commit 7feeb33fd377 (i386: Fix GCC warning with snprintf when 
HAX is enabled)
22/61 Checking commit b3219e531db6 (WHPX: Use proper synchronization primitives 
while processing)
23/61 Checking commit 9ac297a8fdfb (Makefile: Align 'help' target output)
24/61 Checking commit a1ea1d5030be (Makefile: Let the 'help' target list the 
tools targets)
25/61 Checking commit cc21b87564be (hw/audio/fmopl: Move ENV_CURVE to .heap to 
save 32KiB of .bss)
26/61 Checking commit c87784b48f27 (hw/audio/intel-hda: Use memory region alias 
to reduce .rodata by 4.34MB)
27/61 Checking commit 7c3e49f1f8c2 (hw/usb/quirks: Use smaller types to reduce 
.rodata by 10KiB)
28/61 Checking commit d5573acf3dd2 (ui/curses: Make control_characters[] array 
const)
29/61 Checking commit fda402fa8027 (ui/curses: Move arrays to .heap to save 
74KiB of .bss)
30/61 Checking commit cbe6b04b8ba7 (qemu-cpu-models.rst: Document -noTSX, 
mds-no, taa-no, and tsx-ctrl)
31/61 Checking commit 5e28455d64ef (softmmu/vl.c: Handle '-cpu help' and 
'-device help' before 'no default machine')
32/61 Checking commit 46cca43d62a5 (Use -isystem for linux-headers dir)
33/61 Checking commit 3c6d277291bb (exec/rom_reset: Free rom data during 
inmigrate skip)
34/61 Checking commit 773b4360388b (cpus: avoid pause_all_vcpus getting stuck 
due to race)
35/61 Checking commit 7145da746753 (lockable: add lock guards)
36/61 Checking commit 420272a1225a (lockable: add QemuRecMutex support)
37/61 Checking commit af1e8ca6dbe2 (memory: Correctly return alias region type)
38/61 Checking commit af2a71939a4f (memory: Simplify 
memory_region_init_rom_nomigrate() to ease review)
39/61 Checking commit 4fed85522299 (scripts/cocci: Rename 
memory-region-{init-ram -> housekeeping})
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#29: 
rename from scripts/coccinelle/memory-region-init-ram.cocci

total: 0 errors, 1 warnings, 23 lines checked

Patch 39/61 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
40/61 Checking commit 933a6c55666b (scripts/cocci: Patch to replace 
memory_region_init_{ram, readonly -> rom})
41/61 Checking commit 51d745bc839d (hw/arm: Use memory_region_init_rom() with 
read-only regions)
42/61 Checking commit 399ba06a3d1b (hw/display: Use memory_region_init_rom() 
with read-only regions)
43/61 Checking commit ed9cd1f3896b (hw/m68k: Use memory_region_init_rom() with 
read-only regions)
44/61 Checking commit a68500f5aa8d (hw/net: Use memory_region_init_rom() with 
read-only regions)
45/61 Checking commit b105369b07db (hw/pci-host: Use memory_region_init_rom() 
with read-only regions)
46/61 Checking commit ed4826edc121 (hw/ppc: Use memory_region_init_rom() with 
read-only regions)
47/61 Checking commit eb093496af41 (hw/riscv: Use memory_region_init_rom() with 
read-only regions)
48/61 Checking commit 3eb227a952fe (hw/sh4: Use memory_region_init_rom() with 
read-only regions)
49/61 Checking commit 5e2965703af0 (hw/sparc: Use memory_region_init_rom() with 
read-only regions)
50/61 Checking commit 7105f138de3d (scripts/cocci: Patch to detect potential 
use of memory_region_init_rom)
51/61 Checking commit 78397a0d9224 (scripts/cocci: Patch to remove unnecessary 
memory_region_set_readonly())
52/61 Checking commit cbb482607780 (scripts/cocci: Patch to let devices own 
their MemoryRegions)
53/61 Checking commit 2440d3df1140 (hw/core: Let devices own the MemoryRegion 
they create)
54/61 Checking commit 41b094916c6c (hw/display: Let devices own the 
MemoryRegion they create)
55/61 Checking commit 32e82108eb01 (hw/dma: Let devices own the MemoryRegion 
they create)
56/61 Checking commit 5faaec926d2e (hw/riscv: Let devices own the MemoryRegion 
they create)
57/61 Checking commit 37b937cb54f5 (hw/char: Let devices own the MemoryRegion 
they create)
58/61 Checking commit 014a7f6ee9e6 (hw/arm/stm32: Use memory_region_init_rom() 
with read-only regions)
59/61 Checking commit f26c6ecc96b2 (hw/ppc/ppc405: Use memory_region_init_rom() 
with read-only regions)
60/61 Checking commit acefd47b32c7 (hw/arm: Remove unnecessary 
memory_region_set_readonly() on ROM alias)
61/61 Checking commit cd46cc28fc32 (hw/arm: Let devices own the MemoryRegion 
they create)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden