[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 05/19] target/arm: Restrict Virtualization Host Extensions
From: |
Richard Henderson |
Subject: |
Re: [PATCH v3 05/19] target/arm: Restrict Virtualization Host Extensions instructions to TCG |
Date: |
Mon, 16 Mar 2020 13:17:38 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 |
On 3/16/20 9:06 AM, Philippe Mathieu-Daudé wrote:
> Under KVM the ARMv8.1-VHE instruction will trap.
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> target/arm/helper.c | 22 ++++++++++++----------
> 1 file changed, 12 insertions(+), 10 deletions(-)
What happened to the uses of these functions?
r~
>
> diff --git a/target/arm/helper.c b/target/arm/helper.c
> index a5280c091b..ce6778283d 100644
> --- a/target/arm/helper.c
> +++ b/target/arm/helper.c
> @@ -2897,16 +2897,6 @@ static void gt_virt_ctl_write(CPUARMState *env, const
> ARMCPRegInfo *ri,
> gt_ctl_write(env, ri, GTIMER_VIRT, value);
> }
>
> -static void gt_cntvoff_write(CPUARMState *env, const ARMCPRegInfo *ri,
> - uint64_t value)
> -{
> - ARMCPU *cpu = env_archcpu(env);
> -
> - trace_arm_gt_cntvoff_write(value);
> - raw_write(env, ri, value);
> - gt_recalc_timer(cpu, GTIMER_VIRT);
> -}
> -
> static uint64_t gt_virt_redir_cval_read(CPUARMState *env,
> const ARMCPRegInfo *ri)
> {
> @@ -2949,6 +2939,17 @@ static void gt_virt_redir_ctl_write(CPUARMState *env,
> const ARMCPRegInfo *ri,
> gt_ctl_write(env, ri, timeridx, value);
> }
>
> +#if !defined(CONFIG_USER_ONLY) && defined(CONFIG_TCG)
> +static void gt_cntvoff_write(CPUARMState *env, const ARMCPRegInfo *ri,
> + uint64_t value)
> +{
> + ARMCPU *cpu = env_archcpu(env);
> +
> + trace_arm_gt_cntvoff_write(value);
> + raw_write(env, ri, value);
> + gt_recalc_timer(cpu, GTIMER_VIRT);
> +}
> +
> static void gt_hyp_timer_reset(CPUARMState *env, const ARMCPRegInfo *ri)
> {
> gt_timer_reset(env, ri, GTIMER_HYP);
> @@ -2976,6 +2977,7 @@ static void gt_hyp_ctl_write(CPUARMState *env, const
> ARMCPRegInfo *ri,
> {
> gt_ctl_write(env, ri, GTIMER_HYP, value);
> }
> +#endif /* !CONFIG_USER_ONLY && CONFIG_TCG */
>
> static void gt_sec_timer_reset(CPUARMState *env, const ARMCPRegInfo *ri)
> {
>
- [PATCH v3 00/19] Support disabling TCG on ARM (part 2), Philippe Mathieu-Daudé, 2020/03/16
- [PATCH v3 01/19] target/arm: Rename KVM set_feature() as kvm_set_feature(), Philippe Mathieu-Daudé, 2020/03/16
- [PATCH v3 02/19] target/arm: Make set_feature() available for other files, Philippe Mathieu-Daudé, 2020/03/16
- [PATCH v3 03/19] target/arm: Restrict DC-CVAP instruction to TCG accel, Philippe Mathieu-Daudé, 2020/03/16
- [PATCH v3 04/19] target/arm: Restric the Address Translate operations to TCG accel, Philippe Mathieu-Daudé, 2020/03/16
- [PATCH v3 05/19] target/arm: Restrict Virtualization Host Extensions instructions to TCG, Philippe Mathieu-Daudé, 2020/03/16
- Re: [PATCH v3 05/19] target/arm: Restrict Virtualization Host Extensions instructions to TCG,
Richard Henderson <=
- [PATCH v3 06/19] target/arm: Move Makefile variable restricted to CONFIG_TCG, Philippe Mathieu-Daudé, 2020/03/16
- [PATCH v3 08/19] target/arm: Add semihosting stub to allow building without TCG, Philippe Mathieu-Daudé, 2020/03/16
- [PATCH v3 07/19] target/arm: Make cpu_register() available for other files, Philippe Mathieu-Daudé, 2020/03/16
- [PATCH v3 09/19] target/arm: Move ARM_V7M Kconfig from hw/ to target/, Philippe Mathieu-Daudé, 2020/03/16
- [PATCH v3 10/19] target/arm: Restrict ARMv4 cpus to TCG accel, Philippe Mathieu-Daudé, 2020/03/16