[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/3] iotests: Increase pause_wait() timeout
From: |
John Snow |
Subject: |
Re: [PATCH 3/3] iotests: Increase pause_wait() timeout |
Date: |
Mon, 16 Mar 2020 15:58:11 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 |
On 3/13/20 4:36 AM, Kevin Wolf wrote:
> Waiting for only 1 second proved to be too short on a loaded system,
> resulting in false positives when testing pull requests. Increase the
> timeout a bit to make this less likely.
>
> Signed-off-by: Kevin Wolf <address@hidden>
Reviewed-by: John Snow <address@hidden>
> ---
> tests/qemu-iotests/iotests.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
> index b859c303a2..7bc4934cd2 100644
> --- a/tests/qemu-iotests/iotests.py
> +++ b/tests/qemu-iotests/iotests.py
> @@ -925,7 +925,7 @@ class QMPTestCase(unittest.TestCase):
> self.assert_qmp(event, 'data/type', 'mirror')
>
> def pause_wait(self, job_id='job0'):
> - with Timeout(1, "Timeout waiting for job to pause"):
> + with Timeout(3, "Timeout waiting for job to pause"):
> while True:
> result = self.vm.qmp('query-block-jobs')
> found = False
>
- [PATCH 0/3] iotests: Fix intermittent 030 hang, Kevin Wolf, 2020/03/13
- [PATCH 1/3] iotests.py: Enable faulthandler, Kevin Wolf, 2020/03/13
- [PATCH 2/3] python/qemu: Kill QEMU process if 'quit' doesn't work, Kevin Wolf, 2020/03/13
- [PATCH 3/3] iotests: Increase pause_wait() timeout, Kevin Wolf, 2020/03/13
- Re: [PATCH 0/3] iotests: Fix intermittent 030 hang, Philippe Mathieu-Daudé, 2020/03/20
- Re: [PATCH 0/3] iotests: Fix intermittent 030 hang, Peter Maydell, 2020/03/22