[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 22/25] hw/arm/stm32: Use memory_region_init_rom() with read-on
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH v3 22/25] hw/arm/stm32: Use memory_region_init_rom() with read-only regions |
Date: |
Mon, 16 Mar 2020 19:50:03 +0100 |
The scripts/coccinelle/memory-region-housekeeping.cocci reported:
* TODO
[[view:./hw/arm/stm32f205_soc.c::face=ovl-face1::linb=96::colb=4::cole=26][potential
use of memory_region_init_rom*() in ./hw/arm/stm32f205_soc.c::96]]
* TODO
[[view:./hw/arm/stm32f405_soc.c::face=ovl-face1::linb=98::colb=4::cole=26][potential
use of memory_region_init_rom*() in ./hw/arm/stm32f405_soc.c::98]]
We can indeed replace the memory_region_init_ram() and
memory_region_set_readonly() calls by memory_region_init_rom().
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
---
hw/arm/stm32f205_soc.c | 4 +---
hw/arm/stm32f405_soc.c | 4 +---
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/hw/arm/stm32f205_soc.c b/hw/arm/stm32f205_soc.c
index 627fd446f5..2de56275b7 100644
--- a/hw/arm/stm32f205_soc.c
+++ b/hw/arm/stm32f205_soc.c
@@ -93,12 +93,10 @@ static void stm32f205_soc_realize(DeviceState *dev_soc,
Error **errp)
MemoryRegion *flash = g_new(MemoryRegion, 1);
MemoryRegion *flash_alias = g_new(MemoryRegion, 1);
- memory_region_init_ram(flash, NULL, "STM32F205.flash", FLASH_SIZE,
+ memory_region_init_rom(flash, NULL, "STM32F205.flash", FLASH_SIZE,
&error_fatal);
memory_region_init_alias(flash_alias, NULL, "STM32F205.flash.alias",
flash, 0, FLASH_SIZE);
-
- memory_region_set_readonly(flash, true);
memory_region_set_readonly(flash_alias, true);
memory_region_add_subregion(system_memory, FLASH_BASE_ADDRESS, flash);
diff --git a/hw/arm/stm32f405_soc.c b/hw/arm/stm32f405_soc.c
index 9bcad97853..b8fca13f95 100644
--- a/hw/arm/stm32f405_soc.c
+++ b/hw/arm/stm32f405_soc.c
@@ -95,7 +95,7 @@ static void stm32f405_soc_realize(DeviceState *dev_soc, Error
**errp)
Error *err = NULL;
int i;
- memory_region_init_ram(&s->flash, NULL, "STM32F405.flash", FLASH_SIZE,
+ memory_region_init_rom(&s->flash, NULL, "STM32F405.flash", FLASH_SIZE,
&err);
if (err != NULL) {
error_propagate(errp, err);
@@ -103,8 +103,6 @@ static void stm32f405_soc_realize(DeviceState *dev_soc,
Error **errp)
}
memory_region_init_alias(&s->flash_alias, NULL, "STM32F405.flash.alias",
&s->flash, 0, FLASH_SIZE);
-
- memory_region_set_readonly(&s->flash, true);
memory_region_set_readonly(&s->flash_alias, true);
memory_region_add_subregion(system_memory, FLASH_BASE_ADDRESS, &s->flash);
--
2.21.1
- [PATCH v3 13/25] hw/sparc: Use memory_region_init_rom() with read-only regions, (continued)
- [PATCH v3 13/25] hw/sparc: Use memory_region_init_rom() with read-only regions, Philippe Mathieu-Daudé, 2020/03/16
- [PATCH v3 14/25] scripts/cocci: Patch to detect potential use of memory_region_init_rom, Philippe Mathieu-Daudé, 2020/03/16
- [PATCH v3 15/25] scripts/cocci: Patch to remove unnecessary memory_region_set_readonly(), Philippe Mathieu-Daudé, 2020/03/16
- [PATCH v3 16/25] scripts/cocci: Patch to let devices own their MemoryRegions, Philippe Mathieu-Daudé, 2020/03/16
- [PATCH v3 17/25] hw/core: Let devices own the MemoryRegion they create, Philippe Mathieu-Daudé, 2020/03/16
- [PATCH v3 18/25] hw/display: Let devices own the MemoryRegion they create, Philippe Mathieu-Daudé, 2020/03/16
- [PATCH v3 19/25] hw/dma: Let devices own the MemoryRegion they create, Philippe Mathieu-Daudé, 2020/03/16
- [PATCH v3 20/25] hw/riscv: Let devices own the MemoryRegion they create, Philippe Mathieu-Daudé, 2020/03/16
- [PATCH v3 21/25] hw/char: Let devices own the MemoryRegion they create, Philippe Mathieu-Daudé, 2020/03/16
- [PATCH v3 22/25] hw/arm/stm32: Use memory_region_init_rom() with read-only regions,
Philippe Mathieu-Daudé <=
- [PATCH v3 24/25] hw/arm: Remove unnecessary memory_region_set_readonly() on ROM alias, Philippe Mathieu-Daudé, 2020/03/16
- [PATCH v3 23/25] hw/ppc/ppc405: Use memory_region_init_rom() with read-only regions, Philippe Mathieu-Daudé, 2020/03/16
- [PATCH v3 25/25] hw/arm: Let devices own the MemoryRegion they create, Philippe Mathieu-Daudé, 2020/03/16
- [PATCH v3 06/25] hw/display: Use memory_region_init_rom() with read-only regions, Philippe Mathieu-Daudé, 2020/03/16
- Re: [PATCH v3 00/25] hw: Sanitize various MemoryRegion calls, Aleksandar Markovic, 2020/03/16