[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] hw/rdma: avoid suspicious strncpy() use
|
From: |
Juan Quintela |
|
Subject: |
Re: [PATCH 2/2] hw/rdma: avoid suspicious strncpy() use |
|
Date: |
Mon, 16 Mar 2020 18:28:33 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Stefan Hajnoczi <address@hidden> wrote:
> gcc (GCC) 9.2.1 20190827 (Red Hat 9.2.1-1) with sanitizers enabled
> reports the following error:
>
> CC x86_64-softmmu/hw/rdma/vmw/pvrdma_dev_ring.o
> In file included from /usr/include/string.h:495,
> from include/qemu/osdep.h:101,
> from hw/rdma/vmw/pvrdma_dev_ring.c:16:
> In function ‘strncpy’,
> inlined from ‘pvrdma_ring_init’ at hw/rdma/vmw/pvrdma_dev_ring.c:33:5:
> /usr/include/bits/string_fortified.h:106:10: error: ‘__builtin_strncpy’
> specified bound 32 equals destination size [-Werror=stringop-truncation]
> 106 | return __builtin___strncpy_chk (__dest, __src, __len, __bos
> (__dest));
> |
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Use pstrcpy() instead of strncpy(). It is guaranteed to NUL-terminate
> strings.
>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
- [PATCH 1/2] migration: avoid suspicious strncpy() use, (continued)
- [PATCH 1/2] migration: avoid suspicious strncpy() use, Stefan Hajnoczi, 2020/03/16
- Re: [PATCH 1/2] migration: avoid suspicious strncpy() use, Juan Quintela, 2020/03/16
- Re: [PATCH 1/2] migration: avoid suspicious strncpy() use, Philippe Mathieu-Daudé, 2020/03/16
- Re: [PATCH 1/2] migration: avoid suspicious strncpy() use, Eric Blake, 2020/03/16
- Re: [PATCH 1/2] migration: avoid suspicious strncpy() use, Stefan Hajnoczi, 2020/03/17
- Re: [PATCH 1/2] migration: avoid suspicious strncpy() use, Philippe Mathieu-Daudé, 2020/03/17
- Re: [PATCH 1/2] migration: avoid suspicious strncpy() use, Juan Quintela, 2020/03/17
- Re: [PATCH 1/2] migration: avoid suspicious strncpy() use, Stefan Hajnoczi, 2020/03/17
- Re: [PATCH 1/2] migration: avoid suspicious strncpy() use, Juan Quintela, 2020/03/17
[PATCH 2/2] hw/rdma: avoid suspicious strncpy() use, Stefan Hajnoczi, 2020/03/16