[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 18/19] hw/arm: Do not build to 'virt' machine on Xen
From: |
Peter Maydell |
Subject: |
Re: [PATCH v3 18/19] hw/arm: Do not build to 'virt' machine on Xen |
Date: |
Mon, 16 Mar 2020 17:11:42 +0000 |
On Mon, 16 Mar 2020 at 16:08, Philippe Mathieu-Daudé <address@hidden> wrote:
>
> Xen on ARM does not use QEMU machines [*]. Disable the 'virt'
> machine there to avoid odd errors such:
>
> CC i386-softmmu/hw/cpu/a15mpcore.o
> hw/cpu/a15mpcore.c:28:10: fatal error: kvm_arm.h: No such file or directory
>
> [*]
> https://wiki.xenproject.org/wiki/Xen_ARM_with_Virtualization_Extensions#Use_of_qemu-system-i386_on_ARM
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> Cc: Stefano Stabellini <address@hidden>
> Cc: Anthony Perard <address@hidden>
> Cc: Paul Durrant <address@hidden>
> Cc: address@hidden
> ---
> hw/arm/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
> index 8e801cd15f..69a8e30125 100644
> --- a/hw/arm/Kconfig
> +++ b/hw/arm/Kconfig
> @@ -1,5 +1,6 @@
> config ARM_VIRT
> bool
> + depends on !XEN
> default y if KVM
> imply PCI_DEVICES
> imply TEST_DEVICES
> --
This seems odd to me:
(1) the error message you quote is for a15mpcore.c, not virt.c
(2) shouldn't this be prevented by something saying "don't build
guest architecture X boards into Y-softmmu", rather than a specific
flag for a specific arm board ?
thanks
-- PMM
- Re: [PATCH v3 13/19] target/arm: Restrict ARMv7 R-profile cpus to TCG accel, (continued)
- [PATCH v3 14/19] target/arm: Restrict ARMv7 M-profile cpus to TCG accel, Philippe Mathieu-Daudé, 2020/03/16
- [PATCH v3 15/19] target/arm: Make m_helper.c optional via CONFIG_ARM_V7M, Philippe Mathieu-Daudé, 2020/03/16
- [PATCH v3 16/19] target/arm: Do not build TCG objects when TCG is off, Philippe Mathieu-Daudé, 2020/03/16
- [PATCH v3 17/19] hw/arm: Automatically select the 'virt' machine on KVM, Philippe Mathieu-Daudé, 2020/03/16
- [PATCH v3 18/19] hw/arm: Do not build to 'virt' machine on Xen, Philippe Mathieu-Daudé, 2020/03/16
- [PATCH v3 19/19] .travis.yml: Add a KVM-only Aarch64 job, Philippe Mathieu-Daudé, 2020/03/16
- [PATCH v3 12/19] target/arm: Restrict ARMv6 cpus to TCG accel, Philippe Mathieu-Daudé, 2020/03/16
- Re: [PATCH v3 00/19] Support disabling TCG on ARM (part 2), no-reply, 2020/03/16
- Re: [PATCH v3 00/19] Support disabling TCG on ARM (part 2), no-reply, 2020/03/16