[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 24/34] qapi: Replace qmp_dispatch()'s TODO comment by an expla
From: |
Markus Armbruster |
Subject: |
[PATCH v3 24/34] qapi: Replace qmp_dispatch()'s TODO comment by an explanation |
Date: |
Sun, 15 Mar 2020 15:46:43 +0100 |
Signed-off-by: Markus Armbruster <address@hidden>
---
qapi/qmp-dispatch.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/qapi/qmp-dispatch.c b/qapi/qmp-dispatch.c
index 112d29a9ab..fb53687ce9 100644
--- a/qapi/qmp-dispatch.c
+++ b/qapi/qmp-dispatch.c
@@ -164,7 +164,11 @@ QDict *qmp_dispatch(QmpCommandList *cmds, QObject *request,
g_assert(!ret);
return NULL;
} else if (!ret) {
- /* TODO turn into assertion */
+ /*
+ * When the command's schema has no 'returns', cmd->fn()
+ * leaves @ret null. The QMP spec calls for an the empty
+ * object then; supply it.
+ */
ret = QOBJECT(qdict_new());
}
--
2.21.1
- [PATCH v3 05/34] tests/test-qmp-cmds: Factor out qmp_dispatch() test helpers, (continued)
- [PATCH v3 05/34] tests/test-qmp-cmds: Factor out qmp_dispatch() test helpers, Markus Armbruster, 2020/03/15
- [PATCH v3 23/34] qapi: Simplify how qmp_dispatch() gets the request ID, Markus Armbruster, 2020/03/15
- [PATCH v3 02/34] qapi: Belatedly update doc comment for @wait deprecation, Markus Armbruster, 2020/03/15
- [PATCH v3 24/34] qapi: Replace qmp_dispatch()'s TODO comment by an explanation,
Markus Armbruster <=
- [PATCH v3 32/34] qapi: Implement deprecated-input=reject for QMP commands, Markus Armbruster, 2020/03/15
- [PATCH v3 16/34] qapi/schema: Change _make_features() to a take feature list, Markus Armbruster, 2020/03/15
- [PATCH v3 21/34] qapi: Inline do_qmp_dispatch() into qmp_dispatch(), Markus Armbruster, 2020/03/15
- [PATCH v3 08/34] tests/test-qmp-event: Simplify test data setup, Markus Armbruster, 2020/03/15
- [PATCH v3 04/34] docs/devel/qapi-code-gen: Document 'features' introspection, Markus Armbruster, 2020/03/15