Re: [PATCH 00/13] target: Add Renesas RX architecture

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH 00/13] target: Add Renesas RX architecture
Message-id: address@hidden
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
79d6cda Add rx-softmmu
61d5dc4 target/rx: Dump bytes for each insn during disassembly
61f37ba target/rx: Collect all bytes during disassembly
5e44021 target/rx: Emit all disassembly in one prt()
1d7fe28 target/rx: Use prt_ldmi for XCHG_mr disassembly
181dd6d target/rx: Replace operand with prt_ldmi in disassembler
02b4bd4 target/rx: Disassemble rx_index_addr into a string
45dffb0 target/rx: RX disassembler
f481b57 target/rx: CPU definitions
393bf6b target/rx: TCG helpers
d65fdf3 target/rx: TCG translation
330642d MAINTAINERS: Cover Renesas RX architecture
956e3be hw/registerfields.h: Add 8bit and 16bit register macros

=== OUTPUT BEGIN ===
1/13 Checking commit 956e3be0f31c (hw/registerfields.h: Add 8bit and 16bit 
register macros)
Use of uninitialized value in concatenation (.) or string at 
./scripts/checkpatch.pl line 2495.
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#28: FILE: include/hw/registerfields.h:25:
+#define REG8(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) };

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#32: FILE: include/hw/registerfields.h:29:
+#define REG16(reg, addr)                                                  \
+    enum { A_ ## reg = (addr) };                                          \
+    enum { R_ ## reg = (addr) / 2 };

total: 2 errors, 0 warnings, 56 lines checked

Patch 1/13 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/13 Checking commit 330642d32f53 (MAINTAINERS: Cover Renesas RX architecture)
3/13 Checking commit d65fdf35865b (target/rx: TCG translation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21: 
new file mode 100644

total: 0 errors, 1 warnings, 3065 lines checked

Patch 3/13 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/13 Checking commit 393bf6b3880e (target/rx: TCG helpers)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#19: 
new file mode 100644

total: 0 errors, 1 warnings, 650 lines checked

Patch 4/13 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/13 Checking commit f481b5709276 (target/rx: CPU definitions)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21: 
new file mode 100644

total: 0 errors, 1 warnings, 696 lines checked

Patch 5/13 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/13 Checking commit 45dffb0da024 (target/rx: RX disassembler)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#39: 
new file mode 100644

total: 0 errors, 1 warnings, 1497 lines checked

Patch 6/13 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/13 Checking commit 02b4bd4eeca4 (target/rx: Disassemble rx_index_addr into a 
string)
8/13 Checking commit 181dd6d83f88 (target/rx: Replace operand with prt_ldmi in 
disassembler)
9/13 Checking commit 1d7fe289cc4d (target/rx: Use prt_ldmi for XCHG_mr 
disassembly)
10/13 Checking commit 5e44021cea93 (target/rx: Emit all disassembly in one 
prt())
11/13 Checking commit 61f37ba4dba9 (target/rx: Collect all bytes during 
disassembly)
12/13 Checking commit 61d5dc47c3f0 (target/rx: Dump bytes for each insn during 
disassembly)
13/13 Checking commit 79d6cdaded27 (Add rx-softmmu)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#68: 
new file mode 100644

total: 0 errors, 1 warnings, 76 lines checked

Patch 13/13 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden