[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 42/60] target/riscv: widening floating-point/integer type-
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH v5 42/60] target/riscv: widening floating-point/integer type-convert instructions |
|
Date: |
Sat, 14 Mar 2020 16:03:12 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 |
On 3/12/20 7:58 AM, LIU Zhiwei wrote:
> +/*
> + * vfwcvt.f.f.v vd, vs2, vm #
> + * Convert single-width float to double-width float.
> + */
> +static uint32_t vfwcvtffv16(uint16_t a, float_status *s)
> +{
> + return float16_to_float32(a, true, s);
> +}
> +static uint64_t vfwcvtffv32(uint32_t a, float_status *s)
> +{
> + return float32_to_float64(a, s);
> +}
Do you actually need this second one, as opposed to using float32_to_float64
directly?
> +RVVCALL(OPFVV1, vfwcvt_f_f_v_h, WOP_UU_H, H4, H2, vfwcvtffv16)
> +RVVCALL(OPFVV1, vfwcvt_f_f_v_w, WOP_UU_W, H8, H4, vfwcvtffv32)
> +GEN_VEXT_V_ENV(vfwcvt_f_f_v_h, 2, 4, clearl)
> +GEN_VEXT_V_ENV(vfwcvt_f_f_v_w, 4, 8, clearq)
>
Otherwise,
Reviewed-by: Richard Henderson <address@hidden>
r~
- Re: [PATCH v5 38/60] target/riscv: vector floating-point compare instructions, (continued)
- [PATCH v5 40/60] target/riscv: vector floating-point merge instructions, LIU Zhiwei, 2020/03/12
- [PATCH v5 41/60] target/riscv: vector floating-point/integer type-convert instructions, LIU Zhiwei, 2020/03/12
- [PATCH v5 42/60] target/riscv: widening floating-point/integer type-convert instructions, LIU Zhiwei, 2020/03/12
- Re: [PATCH v5 42/60] target/riscv: widening floating-point/integer type-convert instructions,
Richard Henderson <=
- [PATCH v5 43/60] target/riscv: narrowing floating-point/integer type-convert instructions, LIU Zhiwei, 2020/03/12
- [PATCH v5 44/60] target/riscv: vector single-width integer reduction instructions, LIU Zhiwei, 2020/03/12
- [PATCH v5 45/60] target/riscv: vector wideing integer reduction instructions, LIU Zhiwei, 2020/03/12
- [PATCH v5 46/60] target/riscv: vector single-width floating-point reduction instructions, LIU Zhiwei, 2020/03/12
- [PATCH v5 47/60] target/riscv: vector widening floating-point reduction instructions, LIU Zhiwei, 2020/03/12