[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/5] tests/docker: make "buildah bud" output similar to "dock
From: |
Alex Bennée |
Subject: |
Re: [PATCH 2/5] tests/docker: make "buildah bud" output similar to "docker build" |
Date: |
Sat, 14 Mar 2020 15:26:57 +0000 |
User-agent: |
mu4e 1.3.9; emacs 28.0.50 |
Cleber Rosa <address@hidden> writes:
> Podman users will most often be using buildah to build containers.
> Among the differences between "buildah bud|build-using-dockerfile" and
> a traditional "docker build" is that buildah does not run a container
> during build.
>
> To the best of my knowledge and experiments, this means that runtime
> variables, such as ENV from one base image will not propagate into
> another. The end result is that the location for the cross compiler
> binaries, defined in the base "qemu/debian9-mxe" image, are not passed
> through this image. Consequently, the cross compilers are not on PATH
> and the build fails.
>
> Signed-off-by: Cleber Rosa <address@hidden>
Acked-by: Alex Bennée <address@hidden>
> ---
> tests/docker/dockerfiles/debian-win32-cross.docker | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/docker/dockerfiles/debian-win32-cross.docker
> b/tests/docker/dockerfiles/debian-win32-cross.docker
> index 9d7053e59d..d16d6431bc 100644
> --- a/tests/docker/dockerfiles/debian-win32-cross.docker
> +++ b/tests/docker/dockerfiles/debian-win32-cross.docker
> @@ -9,7 +9,7 @@ MAINTAINER Philippe Mathieu-Daudé <address@hidden>
>
> ENV TARGET i686
>
> -ENV PATH $PATH:/usr/lib/mxe/usr/$TARGET-w64-mingw32.shared/bin
> +ENV PATH
> $PATH:/usr/lib/mxe/usr/bin:/usr/lib/mxe/usr/$TARGET-w64-mingw32.shared/bin
>
> ENV PKG_CONFIG_PATH \
>
> $PKG_CONFIG_PATH:/usr/lib/mxe/usr/$TARGET-w64-mingw32.shared/lib/pkgconfig
--
Alex Bennée
- [PATCH 0/5] QEMU Gating CI, Cleber Rosa, 2020/03/12
- [PATCH 1/5] tests/docker: add CentOS 8 Dockerfile, Cleber Rosa, 2020/03/12
- [PATCH 2/5] tests/docker: make "buildah bud" output similar to "docker build", Cleber Rosa, 2020/03/12
- Re: [PATCH 2/5] tests/docker: make "buildah bud" output similar to "docker build",
Alex Bennée <=
- [PATCH 3/5] GitLab CI: avoid calling before_scripts on unintended jobs, Cleber Rosa, 2020/03/12
- [PATCH 4/5] GitLab Gating CI: introduce pipeline-status contrib script, Cleber Rosa, 2020/03/12
- [PATCH 5/5] GitLab Gating CI: initial set of jobs, documentation and scripts, Cleber Rosa, 2020/03/12
- Re: [PATCH 0/5] QEMU Gating CI, Peter Maydell, 2020/03/12