[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 15/60] target/riscv: vector integer comparison instruction
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH v5 15/60] target/riscv: vector integer comparison instructions |
|
Date: |
Fri, 13 Mar 2020 23:33:20 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 |
On 3/12/20 7:58 AM, LIU Zhiwei wrote:
> +/* Vector Integer Comparison Instructions */
> +#define DO_MSEQ(N, M) ((N == M) ? 1 : 0)
> +#define DO_MSNE(N, M) ((N != M) ? 1 : 0)
> +#define DO_MSLTU(N, M) ((N < M) ? 1 : 0)
> +#define DO_MSLT(N, M) ((N < M) ? 1 : 0)
> +#define DO_MSLEU(N, M) ((N <= M) ? 1 : 0)
> +#define DO_MSLE(N, M) ((N <= M) ? 1 : 0)
> +#define DO_MSGTU(N, M) ((N > M) ? 1 : 0)
> +#define DO_MSGT(N, M) ((N > M) ? 1 : 0)
You can drop the ? 1 : 0. You can drop the LT/LTU (etc) distinction, since
that comes from the type.
Otherwise,
Reviewed-by: Richard Henderson <address@hidden>
r~
- Re: [PATCH v5 11/60] target/riscv: vector integer add-with-carry / subtract-with-borrow instructions, (continued)
[PATCH v5 12/60] target/riscv: vector bitwise logical instructions, LIU Zhiwei, 2020/03/12
[PATCH v5 13/60] target/riscv: vector single-width bit shift instructions, LIU Zhiwei, 2020/03/12
[PATCH v5 14/60] target/riscv: vector narrowing integer right shift instructions, LIU Zhiwei, 2020/03/12
[PATCH v5 15/60] target/riscv: vector integer comparison instructions, LIU Zhiwei, 2020/03/12
- Re: [PATCH v5 15/60] target/riscv: vector integer comparison instructions,
Richard Henderson <=
[PATCH v5 16/60] target/riscv: vector integer min/max instructions, LIU Zhiwei, 2020/03/12
[PATCH v5 17/60] target/riscv: vector single-width integer multiply instructions, LIU Zhiwei, 2020/03/12
[PATCH v5 18/60] target/riscv: vector integer divide instructions, LIU Zhiwei, 2020/03/12
[PATCH v5 19/60] target/riscv: vector widening integer multiply instructions, LIU Zhiwei, 2020/03/12
[PATCH v5 20/60] target/riscv: vector single-width integer multiply-add instructions, LIU Zhiwei, 2020/03/12