Re: [PATCH v3 08/16] hw/i386/vmport: Define enum for all commands

[Liran Alon]

On 13/03/2020 21:59, Philippe Mathieu-Daudé wrote:
> On 3/12/20 5:54 PM, Liran Alon wrote:
> > No functional change.
> >
> > Defining an enum for all VMPort commands have the following advantages:
> > * It gets rid of the error-prone requirement to update VMPORT_ENTRIES
> > when new VMPort commands are added to QEMU.
> > * It makes it clear to know by looking at one place at the source, what
> > are all the VMPort commands supported by QEMU.
> >
> > Reviewed-by: Nikita Leshenko <address@hidden>
> > Signed-off-by: Liran Alon <address@hidden>
> > ---
> >   hw/i386/vmmouse.c        | 18 ++++++------------
> >   hw/i386/vmport.c         | 11 ++---------
> >   include/hw/i386/vmport.h | 11 ++++++++++-
>
> Please setup scripts/git.orderfile to ease reviews.
>
> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Oh ok. Will do for next submissions.

Thanks,
-Liran