Re: [PATCH v2 0/3]: acpi: Add Windows ACPI Emulated Device Table (WAET)

[Liran Alon]

On 13/03/2020 17:58, address@hidden wrote:
> Patchew URL: 
> https://urldefense.com/v3/__https://patchew.org/QEMU/address@hidden/__;!!GqivPVa7Brio!MCIj6t775fgVLQyuc_7yakcjRzbRpb0QfWeBkZaMwb72--7RvXHTCgm_18diSyk$
>
>
>
> Hi,
>
> This series seems to have some coding style problems. See output below for
> more information:
>
> Subject: [PATCH v2 0/3]: acpi: Add Windows ACPI Emulated Device Table (WAET)
> Message-id: address@hidden
> Type: series
>
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
> git rev-parse base > /dev/null || exit 0
> git config --local diff.renamelimit 0
> git config --local diff.renames True
> git config --local diff.algorithm histogram
> ./scripts/checkpatch.pl --mailback base..
> === TEST SCRIPT END ===
>
> Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
> Switched to a new branch 'test'
> e9129fb acpi: unit-test: Update WAET ACPI Table expected binaries
> 76eaa7a acpi: Add Windows ACPI Emulated Device Table (WAET)
> 041dfae acpi: unit-test: Ignore diff in WAET ACPI table
>
> === OUTPUT BEGIN ===
> 1/3 Checking commit 041dfaefd37e (acpi: unit-test: Ignore diff in WAET ACPI 
> table)
> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> #17:
> new file mode 100644
>
> total: 0 errors, 1 warnings, 3 lines checked
>
> Patch 1/3 has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> 2/3 Checking commit 76eaa7ac6ef4 (acpi: Add Windows ACPI Emulated Device Table 
> (WAET))
> ERROR: line over 90 characters
> #43: FILE: hw/i386/acpi-build.c:2520:
> + * Spec: 
> https://urldefense.com/v3/__http://download.microsoft.com/download/7/E/7/7E7662CF-CBEA-470B-A97E-CE7CE0D98DC2/WAET.docx__;!!GqivPVa7Brio!MCIj6t775fgVLQyuc_7yakcjRzbRpb0QfWeBkZaMwb72--7RvXHTCgm_RmMn38k$
Just wanted to note that this is intentional. I didn't want to break the 
URL to multiple lines.
> WARNING: Block comments use a leading /* on a separate line
> #61: FILE: hw/i386/acpi-build.c:2538:
> +    build_append_int_noprefix(table_data, 1 << 1 /* ACPI PM timer good */, 4);
Same here. Intentional. Seems to match the coding convention of other 
places in acpi-build.c.
> total: 1 errors, 1 warnings, 43 lines checked
>
> Patch 2/3 has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
>
> 3/3 Checking commit e9129fbd5cf2 (acpi: unit-test: Update WAET ACPI Table 
> expected binaries)
> === OUTPUT END ===
>
> Test command exited with code: 1
>
>
> The full log is available at
> https://urldefense.com/v3/__http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message__;!!GqivPVa7Brio!MCIj6t775fgVLQyuc_7yakcjRzbRpb0QfWeBkZaMwb72--7RvXHTCgm_VGFnBLg$
>  .
> ---
> Email generated automatically by Patchew 
> [https://urldefense.com/v3/__https://patchew.org/__;!!GqivPVa7Brio!MCIj6t775fgVLQyuc_7yakcjRzbRpb0QfWeBkZaMwb72--7RvXHTCgm_RlK35c8$
>  ].
> Please send your feedback to address@hidden