[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 7/7] via-ide: always use legacy IRQ 14/15 routing
From: |
Mark Cave-Ayland |
Subject: |
[PATCH 7/7] via-ide: always use legacy IRQ 14/15 routing |
Date: |
Fri, 13 Mar 2020 08:24:44 +0000 |
The existing code uses fixed PCI IRQ routing on IRQ 14 rather than legacy IRQ
14/15 routing as documented in the datasheet.
With the changes in this patchset guest OSs now correctly detect and configure
the VIA controller in legacy IRQ routing mode, allowing the incorrect fixed
PCI IRQ routing to be removed.
Note that this fixed legacy IRQ 14/15 routing is identical to similar behaviour
in the early PIIX IDE controllers.
Signed-off-by: Mark Cave-Ayland <address@hidden>
---
hw/ide/via.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/hw/ide/via.c b/hw/ide/via.c
index 3c4d474e48..8de4945cc1 100644
--- a/hw/ide/via.c
+++ b/hw/ide/via.c
@@ -113,10 +113,7 @@ static void via_ide_set_irq(void *opaque, int n, int level)
}
level = (d->config[0x70] & 0x80) || (d->config[0x78] & 0x80);
- n = pci_get_byte(d->config + PCI_INTERRUPT_LINE);
- if (n) {
- qemu_set_irq(isa_get_irq(NULL, n), level);
- }
+ qemu_set_irq(isa_get_irq(NULL, 14 + n), level);
}
static void via_ide_reset(DeviceState *dev)
--
2.20.1
- [PATCH 0/7] via-ide: fixes and improvements, Mark Cave-Ayland, 2020/03/13
- [PATCH 1/7] via-ide: move registration of VMStateDescription to DeviceClass, Mark Cave-Ayland, 2020/03/13
- [PATCH 3/7] pci: Honour wmask when resetting PCI_INTERRUPT_LINE, Mark Cave-Ayland, 2020/03/13
- [PATCH 2/7] ide/via: Get rid of via_ide_init(), Mark Cave-Ayland, 2020/03/13
- [PATCH 4/7] via-ide: ensure that PCI_INTERRUPT_LINE is hard-wired to its default value, Mark Cave-Ayland, 2020/03/13
- [PATCH 5/7] via-ide: initialise IDE controller in legacy mode, Mark Cave-Ayland, 2020/03/13
- [PATCH 6/7] via-ide: allow guests to write to PCI_CLASS_PROG, Mark Cave-Ayland, 2020/03/13
- [PATCH 7/7] via-ide: always use legacy IRQ 14/15 routing,
Mark Cave-Ayland <=
- Re: [PATCH 0/7] via-ide: fixes and improvements, BALATON Zoltan, 2020/03/13
- Re: [EXTERNAL][PATCH 0/7] via-ide: fixes and improvements, Aleksandar Markovic, 2020/03/13
- Re: [PATCH 0/7] via-ide: fixes and improvements, John Snow, 2020/03/13