Re: [PATCH] virtio_balloon: Add option mprotect to handle guest kernel cheat issue

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH] virtio_balloon: Add option mprotect to handle guest kernel 
cheat issue
Message-id: address@hidden
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
   6e8a73e..5931ed5  master     -> master
Switched to a new branch 'test'
4528326 virtio_balloon: Add option mprotect to handle guest kernel cheat issue

=== OUTPUT BEGIN ===
WARNING: Block comments use a leading /* on a separate line
#224: FILE: hw/virtio/virtio-balloon.c:126:
+        /* We ignore errors from __ram_block_discard_range(), because it

ERROR: braces {} are necessary for all arms of this statement
#232: FILE: hw/virtio/virtio-balloon.c:150:
+    if (balloon->do_mprotect)
[...]

total: 1 errors, 1 warnings, 181 lines checked

Commit 4528326453b1 (virtio_balloon: Add option mprotect to handle guest kernel 
cheat issue) has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden