Re: [kvm-unit-tests PATCH v6 07/13] arm/arm64: ITS: its_enable_defaults

[Andrew Jones]

On Wed, Mar 11, 2020 at 02:51:11PM +0100, Eric Auger wrote:
> +/* must be called after gicv3_enable_defaults */
> +void its_enable_defaults(void)
> +{
> +     int i;
> +
> +     /* Allocate LPI config and pending tables */
> +     gicv3_lpi_alloc_tables();
> +
> +     for (i = 0; i < nr_cpus; i++)
> +             gicv3_lpi_rdist_enable(i);

You still haven't explained what's wrong with for_each_present_cpu. Also,
I see you've added 'i < nr_cpus' loops in arm/gic.c too. I'd prefer we not
assume that all cpu's are present (even though, currently, they must be),
because we may want to integrate cpu hotplug tests with these tests at
some point.

> +
> +     writel(GITS_CTLR_ENABLE, its_data.base + GITS_CTLR);
> +}
> -- 
> 2.20.1
> 
>