[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 01/13] hw/i386: Introduce X86CPUTopoInfo to contain topolo
From: |
Igor Mammedov |
Subject: |
Re: [PATCH v6 01/13] hw/i386: Introduce X86CPUTopoInfo to contain topology info |
Date: |
Wed, 11 Mar 2020 16:26:56 +0100 |
On Wed, 11 Mar 2020 09:02:58 -0500
Babu Moger <address@hidden> wrote:
> On 3/11/20 6:39 AM, Igor Mammedov wrote:
> > On Tue, 10 Mar 2020 21:33:25 -0500
> > Babu Moger <address@hidden> wrote:
> >
> >> This is an effort to re-arrange few data structure for better readability.
> >>
> >> 1. Add X86CPUTopoInfo which will have all the topology informations
> >> required to build the cpu topology. There is no functional changes.
> >>
> >> 2. Introduce init_topo_info to initialize X86CPUTopoInfo members from
> >> X86MachineState.
> >>
> >> 3. Update x86 unit tests for new calling convention with parameter
> >> X86CPUTopoInfo
> >>
> >> There is no functional changes.
> >
> > patch doesn't apply to current master, so I can't really test it
>
> I generated the patches on top of Eduardo's tree.
>
> It should work if you apply after this patch.
>
> https://lore.kernel.org/qemu-devel/address@hidden/
thanks it helps
other than minor nit patch looks fine to me, so
Acked-by: Igor Mammedov <address@hidden>
> Do you want me to generate on top of master ?
no need, if series is not based on master we usually
put in the cover letter a link to the tree and branch series depends on
>
> >>
> >> Signed-off-by: Babu Moger <address@hidden>
> >> ---
> >> hw/i386/pc.c | 12 ++++++------
> >> hw/i386/x86.c | 32 ++++++++++++++++++++++++--------
> >> include/hw/i386/topology.h | 38 ++++++++++++++++++++++++--------------
> >> include/hw/i386/x86.h | 3 +++
> >> tests/test-x86-cpuid.c | 43
> >> ++++++++++++++++++++++++-------------------
> >> 5 files changed, 81 insertions(+), 47 deletions(-)
> >>
> > [...]
> >> diff --git a/hw/i386/x86.c b/hw/i386/x86.c
> >> index 322fb6abbc..03b8962c98 100644
> >> --- a/hw/i386/x86.c
> >> +++ b/hw/i386/x86.c
> >> @@ -57,6 +57,16 @@
> >> /* Physical Address of PVH entry point read from kernel ELF NOTE */
> >> static size_t pvh_start_addr;
> >>
> >> +inline void init_topo_info(X86CPUTopoInfo *topo_info,
> >> + const X86MachineState *x86ms)
> >
> > not aligned properly
>
> Will fix it.
>
> >
> > [...]
> >
>
- [PATCH v6 00/13] APIC ID fixes for AMD EPYC CPU model, Babu Moger, 2020/03/10
- [PATCH v6 02/13] hw/i386: Consolidate topology functions, Babu Moger, 2020/03/10
- [PATCH v6 03/13] machine: Add SMP Sockets in CpuTopology, Babu Moger, 2020/03/10
- [PATCH v6 04/13] hw/i386: Remove unnecessary initialization in x86_cpu_new, Babu Moger, 2020/03/10
- [PATCH v6 05/13] hw/i386: Update structures to save the number of nodes per package, Babu Moger, 2020/03/10
- [PATCH v6 06/13] hw/i386: Rename apicid_from_topo_ids to x86_apicid_from_topo_ids, Babu Moger, 2020/03/10
- [PATCH v6 07/13] hw/386: Add EPYC mode topology decoding functions, Babu Moger, 2020/03/10
- [PATCH v6 08/13] target/i386: Cleanup and use the EPYC mode topology functions, Babu Moger, 2020/03/10
- [PATCH v6 09/13] hw/i386: Introduce apicid functions inside X86MachineState, Babu Moger, 2020/03/10