Re: [PULL 0/9] Block patches

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PULL 0/9] Block patches
Message-id: address@hidden
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
3dc47c6 aio-posix: remove idle poll handlers to improve scalability
58ca23d aio-posix: support userspace polling of fd monitoring
fc5884c aio-posix: add io_uring fd monitoring implementation
77f63d6 aio-posix: simplify FDMonOps->update() prototype
d62d100 aio-posix: extract ppoll(2) and epoll(7) fd monitoring
dbbbe69 aio-posix: move RCU_READ_LOCK() into run_poll_handlers()
939cafa aio-posix: completely stop polling when disabled
426425b aio-posix: remove confusing QLIST_SAFE_REMOVE()
86ac8a7 qemu/queue.h: clear linked list pointers on remove

=== OUTPUT BEGIN ===
1/9 Checking commit 86ac8a79649d (qemu/queue.h: clear linked list pointers on 
remove)
ERROR: do not use assignment in if condition
#66: FILE: include/qemu/queue.h:314:
+    if (((head)->sqh_first = elm->field.sqe_next) == NULL)              \

total: 1 errors, 0 warnings, 59 lines checked

Patch 1/9 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/9 Checking commit 426425ba6bc2 (aio-posix: remove confusing 
QLIST_SAFE_REMOVE())
3/9 Checking commit 939cafa1cf7f (aio-posix: completely stop polling when 
disabled)
4/9 Checking commit dbbbe69aa8fd (aio-posix: move RCU_READ_LOCK() into 
run_poll_handlers())
5/9 Checking commit d62d1006e571 (aio-posix: extract ppoll(2) and epoll(7) fd 
monitoring)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#469: 
new file mode 100644

total: 0 errors, 1 warnings, 721 lines checked

Patch 5/9 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/9 Checking commit 77f63d653496 (aio-posix: simplify FDMonOps->update() 
prototype)
7/9 Checking commit fc5884cb93cc (aio-posix: add io_uring fd monitoring 
implementation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#186: 
new file mode 100644

total: 0 errors, 1 warnings, 456 lines checked

Patch 7/9 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/9 Checking commit 58ca23deb3e6 (aio-posix: support userspace polling of fd 
monitoring)
9/9 Checking commit 3dc47c6d2f6a (aio-posix: remove idle poll handlers to 
improve scalability)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden