[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 25/33] hw/i386/pc: Clean up includes
From: |
Laurent Vivier |
Subject: |
[PULL 25/33] hw/i386/pc: Clean up includes |
Date: |
Mon, 9 Mar 2020 16:08:29 +0100 |
From: Philippe Mathieu-Daudé <address@hidden>
Various headers are not required by hw/i386/pc.h:
- "qemu/range.h"
- "qemu/bitmap.h"
- "qemu/module.h"
- "exec/memory.h"
- "hw/pci/pci.h"
- "hw/mem/pc-dimm.h"
- "hw/mem/nvdimm.h"
- "net/net.h"
Remove them.
Add 3 headers that were missing:
- "hw/hotplug.h"
PCMachineState::acpi_dev is of type HotplugHandler
- "qemu/notify.h"
PCMachineState::machine_done is of type Notifier
- "qapi/qapi-types-common.h"
PCMachineState::vmport/smm is of type OnOffAuto
Acked-by: John Snow <address@hidden>
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Laurent Vivier <address@hidden>
---
include/hw/i386/pc.h | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
index d5ac76d54e1f..6ab6eda046fd 100644
--- a/include/hw/i386/pc.h
+++ b/include/hw/i386/pc.h
@@ -1,20 +1,15 @@
#ifndef HW_PC_H
#define HW_PC_H
-#include "exec/memory.h"
+#include "qemu/notify.h"
+#include "qapi/qapi-types-common.h"
#include "hw/boards.h"
#include "hw/block/fdc.h"
#include "hw/block/flash.h"
-#include "net/net.h"
#include "hw/i386/x86.h"
-#include "qemu/range.h"
-#include "qemu/bitmap.h"
-#include "qemu/module.h"
-#include "hw/pci/pci.h"
-#include "hw/mem/pc-dimm.h"
-#include "hw/mem/nvdimm.h"
#include "hw/acpi/acpi_dev_interface.h"
+#include "hw/hotplug.h"
#define HPET_INTCAP "hpet-intcap"
--
2.24.1
- [PULL 10/33] hw/i386/ioapic_internal: Remove unused "hw/i386/ioapic.h" header, (continued)
- [PULL 10/33] hw/i386/ioapic_internal: Remove unused "hw/i386/ioapic.h" header, Laurent Vivier, 2020/03/09
- [PULL 14/33] hw/alpha/alpha_sys: Remove unused "hw/ide.h" header, Laurent Vivier, 2020/03/09
- [PULL 20/33] hw/i2c/smbus_ich9: Include "qemu/range.h", Laurent Vivier, 2020/03/09
- [PULL 17/33] hw/acpi/cpu_hotplug: Include "hw/pci/pci.h", Laurent Vivier, 2020/03/09
- [PULL 18/33] hw/timer/hpet: Include "exec/address-spaces.h", Laurent Vivier, 2020/03/09
- [PULL 22/33] hw/acpi: Include "hw/mem/nvdimm.h", Laurent Vivier, 2020/03/09
- [PULL 21/33] hw/pci-host/piix: Include "qemu/range.h", Laurent Vivier, 2020/03/09
- [PULL 26/33] core/qdev: fix memleak in qdev_get_gpio_out_connector(), Laurent Vivier, 2020/03/09
- [PULL 07/33] virtfs-proxy-helper: Make the helper_opts[] array const, Laurent Vivier, 2020/03/09
- [PULL 16/33] hw/hppa/machine: Include "net/net.h", Laurent Vivier, 2020/03/09
- [PULL 25/33] hw/i386/pc: Clean up includes,
Laurent Vivier <=
- [PULL 23/33] hw/i386: Include "hw/mem/nvdimm.h", Laurent Vivier, 2020/03/09
- [PULL 28/33] block/file-posix: Remove redundant statement in raw_handle_perm_lock(), Laurent Vivier, 2020/03/09
- [PULL 31/33] display/pxa2xx_lcd: Remove redundant statement in pxa2xx_palette_parse(), Laurent Vivier, 2020/03/09
- [PULL 32/33] display/exynos4210_fimd: Remove redundant statement in exynos4210_fimd_update(), Laurent Vivier, 2020/03/09
- [PULL 24/33] hw/pci-host/q35: Remove unused includes, Laurent Vivier, 2020/03/09
- [PULL 27/33] block/stream: Remove redundant statement in stream_run(), Laurent Vivier, 2020/03/09
- [PULL 30/33] scsi/scsi-disk: Remove redundant statement in scsi_disk_emulate_command(), Laurent Vivier, 2020/03/09
- [PULL 33/33] monitor/hmp-cmds: Remove redundant statement in hmp_rocker_of_dpa_groups(), Laurent Vivier, 2020/03/09
- [PULL 29/33] dma/xlnx-zdma: Remove redundant statement in zdma_write_dst(), Laurent Vivier, 2020/03/09
- Re: [PULL 00/33] Trivial branch patches, no-reply, 2020/03/09