[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/6] hw/net/rtl8139: Update coding style to make checkpatch.p
From: |
Cédric Le Goater |
Subject: |
Re: [PATCH 4/6] hw/net/rtl8139: Update coding style to make checkpatch.pl happy |
Date: |
Fri, 6 Mar 2020 16:26:46 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 |
On 3/5/20 6:56 PM, Philippe Mathieu-Daudé wrote:
> We will modify this code in the next commit. Clean it up
> first to avoid checkpatch.pl errors.
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Cédric Le Goater <address@hidden>
> ---
> hw/net/rtl8139.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/hw/net/rtl8139.c b/hw/net/rtl8139.c
> index ef3211537f..be9a0af629 100644
> --- a/hw/net/rtl8139.c
> +++ b/hw/net/rtl8139.c
> @@ -799,10 +799,12 @@ static int rtl8139_can_receive(NetClientState *nc)
> int avail;
>
> /* Receive (drop) packets if card is disabled. */
> - if (!s->clock_enabled)
> - return 1;
> - if (!rtl8139_receiver_enabled(s))
> - return 1;
> + if (!s->clock_enabled) {
> + return 1;
> + }
> + if (!rtl8139_receiver_enabled(s)) {
> + return 1;
> + }
>
> if (rtl8139_cp_receiver_enabled(s) && rtl8139_cp_rx_valid(s)) {
> /* ??? Flow control not implemented in c+ mode.
>
- Re: [PATCH 1/6] hw/net/e1000e_core: Let e1000e_can_receive() return a boolean, (continued)
- [PATCH 2/6] hw/net/smc91c111: Let smc91c111_can_receive() return a boolean, Philippe Mathieu-Daudé, 2020/03/05
- [PATCH 3/6] hw/net/rtl8139: Simplify if/else statement, Philippe Mathieu-Daudé, 2020/03/05
- [PATCH 4/6] hw/net/rtl8139: Update coding style to make checkpatch.pl happy, Philippe Mathieu-Daudé, 2020/03/05
- [PATCH 6/6] hw/net/can: Make CanBusClientInfo::can_receive() return a boolean, Philippe Mathieu-Daudé, 2020/03/05
- [PATCH 5/6] hw/net: Make NetCanReceive() return a boolean, Philippe Mathieu-Daudé, 2020/03/05
- Re: [PATCH 0/6] hw/net: Make Net/CanBus can_receive() handlers return a boolean, Philippe Mathieu-Daudé, 2020/03/17