Re: [PULL 000/136] Misc patches for 2020-02-25 (refactoring and Coccinelle edition)

[Christian Borntraeger]

And with
diff --git a/util/oslib-posix.c b/util/oslib-posix.c
index 897e8f3ba6..5d95a2049b 100644
--- a/util/oslib-posix.c
+++ b/util/oslib-posix.c
@@ -470,6 +470,7 @@ static bool touch_all_pages(char *area, size_t hpagesize, 
size_t numpages,
     char *addr = area;
     int i = 0;
 
+    qemu_cond_init(&page_cond);
     memset_thread_failed = false;
     threads_created_flag = false;
     memset_num_threads = get_memset_num_threads(smp_cpus);

I get the next one:

qemu-system-s390x: /home/cborntra/REPOS/qemu/util/qemu-thread-posix.c:76: 
qemu_mutex_lock_impl: Assertion `mutex->initialized' failed.



On 06.03.20 09:34, Christian Borntraeger wrote:
> 
> 
> On 06.03.20 09:02, Christian Borntraeger wrote:
>>
>> On 25.02.20 12:48, Paolo Bonzini wrote:
>>> The following changes since commit c1e667d2598b9b3ce62b8e89ed22dd38dfe9f57f:
>>>
>>>   Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' 
>>> into staging (2020-02-24 11:38:54 +0000)
>>>
>>> are available in the git repository at:
>>>
>>>
>>>   git://github.com/bonzini/qemu.git tags/for-upstream
>>>
>>> for you to fetch changes up to 4db373bef1544b3b5e02ed376d0788c5b6a7548b:
>>>
>>>   Merge branch 'exec_rw_const_v4' of https://github.com/philmd/qemu into 
>>> HEAD (2020-02-25 09:37:42 +0100)
>>>
>>> ----------------------------------------------------------------
>>>
>>> * device_del fix (Julia)
>>> * FXAM fix (myself)
>>> * memdev refactoring (Igor)
>>> * memory region API cleanups (Peter, Philippe)
>>
>> Marc Hartmayer reported the following 
>> qemu-system-s390x: /home/cborntra/REPOS/qemu/util/qemu-thread-posix.c:161: 
>> qemu_cond_broadcast: Assertion `cond->initialized' failed.
>>
>> I can reproduce that as soon as I use -mem-path and -mem-prealloc together.
>>
> 
> Ok I bisected this to 
> 
> commit 037fb5eb3941c80a2b7c36a843e47207ddb004d4
> Author: bauerchen <address@hidden>
> Date:   Tue Feb 11 17:10:35 2020 +0800
> 
>     mem-prealloc: optimize large guest startup
>