Re: [PATCH v6 10/18] s390x: protvirt: SCLP interpretation

[David Hildenbrand]

>>>  #endif
>>> diff --git a/target/s390x/kvm.c b/target/s390x/kvm.c
>>> index 43fc0c088b..a4cbdc5fc6 100644
>>> --- a/target/s390x/kvm.c
>>> +++ b/target/s390x/kvm.c
>>> @@ -1226,6 +1226,11 @@ static void kvm_sclp_service_call(S390CPU *cpu, 
>>> struct kvm_run *run,
>>>      sccb = env->regs[ipbh0 & 0xf];
>>>      code = env->regs[(ipbh0 & 0xf0) >> 4];
>>>  
>>> +    if (run->s390_sieic.icptcode == ICPT_PV_INSTR) {
>>
>> I still somewhat prefer checking for env->pv instead - similar to patch #9.
> 
> Since we also have a notification for SCLP, I'd like to avoid that.
> And that reminds me that we should add a check for the notification
> here, so we get notified if KVM changes and let's those through without
> qemu being prepared for it.

Makes sense then! This will also make it clearer why we're not checking
against pv.


-- 
Thanks,

David / dhildenb