Re: [PATCH v2 00/14] tests/vm: Add support for aarch64 VMs

[Robert Foley]

On Mon, 2 Mar 2020 at 11:38, Alex Bennée <address@hidden> wrote:
>
>
> Robert Foley <address@hidden> writes:
>
> > This is version 2 of the patch series to
> > add support for aarch64 VMs.
> >  - Ubuntu 18.04 aarch64 VM
> >  - CentOS 8 aarch64 VM
>
> For now I've pulled the first 5 patches into testing/next as they are
> obvious clean-ups.
>
> >   tests/vm: Add workaround to consume console
>
> I still have concerns about this approach but I'm going to give it some
> more testing.

We are happy to make any adjustments here.  Our first set of
refactoring here was
aimed at making it more pythonic.  Is this where the concerns are?

> However I ran into problems testing on my aarch64 box
> because of a missing gen-iso-image which makes me think we need to add
> some gating via configure for tools and libraries we need.

Should we error out in configure if the tools and libraries needed to build the
VMs are not there?
Or maybe tolerate these dependencies not being there at configure time and
provide an error later when someone tries to vm-build these VMs?
Just curious which approach we should pursue here.


Thanks & Regards,
-Rob