[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 12/15] util: vfio-helpers: Implement ram_block_resized()
From: |
David Hildenbrand |
Subject: |
Re: [PATCH v3 12/15] util: vfio-helpers: Implement ram_block_resized() |
Date: |
Mon, 2 Mar 2020 16:01:33 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 28.02.20 22:01, Peter Xu wrote:
> On Fri, Feb 28, 2020 at 09:16:28PM +0100, David Hildenbrand wrote:
>>
>
> [...]
>
>>>> @@ -631,7 +658,7 @@ int qemu_vfio_dma_map(QEMUVFIOState *s, void *host,
>>>> size_t size,
>>>> qemu_vfio_remove_mapping(s, mapping);
>>>> goto out;
>>>> }
>>>> - s->low_water_mark += size;
>>>> + s->low_water_mark += max_size;
>>>
>>> I think it's fine to only increase the low water mark here, however
>>> imo it would be better to also cache the max size in IOVAMapping too,
>>> then in resize() we double check new_size <= max_size? It also makes
>>> IOVAMapping more self contained.
>>>
>>
>> I‘ll have a look how much additional code that will imply - if it‘s simple,
>> I‘ll do it.
>
> AFAICT it'll be as simple as introducing IOVAMapping.max_size, then
> pass max_size into qemu_vfio_add_mapping(). Thanks,
>
Yeah, was answering from my mobile without code at hand :) added! Thanks!
--
Thanks,
David / dhildenb
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH v3 12/15] util: vfio-helpers: Implement ram_block_resized(),
David Hildenbrand <=