[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 4/9] hw/display/artist: Avoid drawing line when nothing to dis
From: |
Sven Schnelle |
Subject: |
Re: [PULL 4/9] hw/display/artist: Avoid drawing line when nothing to display |
Date: |
Sat, 29 Feb 2020 10:31:11 +0100 |
User-agent: |
Mutt/1.12.2 (2019-09-21) |
On Tue, Feb 18, 2020 at 11:39:24AM -0800, Richard Henderson wrote:
> From: Philippe Mathieu-Daudé <address@hidden>
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> Message-Id: <address@hidden>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
> hw/display/artist.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/hw/display/artist.c b/hw/display/artist.c
> index 97c811b35e..5492079116 100644
> --- a/hw/display/artist.c
> +++ b/hw/display/artist.c
> @@ -579,6 +579,9 @@ static void draw_line(ARTISTState *s, int x1, int y1, int
> x2, int y2,
> } else {
> dy = y1 - y2;
> }
> + if (!dx || !dy) {
> + return;
> + }
>
> c1 = false;
> if (dy > dx) {
> --
> 2.20.1
>
>
I noticed that this change causes 1px wide lines to disappear. So i would
propose
to revert that change.
Regards
Sven
- [PULL 0/9] target/hppa patch queue, Richard Henderson, 2020/02/18
- [PULL 1/9] hw/display/artist: Move trace event to draw_line(), Richard Henderson, 2020/02/18
- [PULL 2/9] hw/display/artist: Remove pointless initialization, Richard Henderson, 2020/02/18
- [PULL 3/9] hw/display/artist: Delay some variables initialization, Richard Henderson, 2020/02/18
- [PULL 4/9] hw/display/artist: Avoid drawing line when nothing to display, Richard Henderson, 2020/02/18
- Re: [PULL 4/9] hw/display/artist: Avoid drawing line when nothing to display,
Sven Schnelle <=
- [PULL 5/9] hw/display/artist: Remove dead code (CID 1419388 & 1419389), Richard Henderson, 2020/02/18
- [PULL 6/9] hw/hppa/dino: Add comments with register name, Richard Henderson, 2020/02/18
- [PULL 7/9] hw/hppa/dino: Fix reg800_keep_bits overrun (CID 1419387 1419393 1419394), Richard Henderson, 2020/02/18
- [PULL 8/9] hw/hppa/dino: Fix bitmask for the PCIROR register, Richard Henderson, 2020/02/18
- [PULL 9/9] hw/hppa/dino: Do not accept accesses to registers 0x818 and 0x82c, Richard Henderson, 2020/02/18
- Re: [PULL 0/9] target/hppa patch queue, Peter Maydell, 2020/02/20