[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 7/8] accel/tcg: only USE_STATIC_CODE_GEN_BUFFER on 32 bit hosts
From: |
Richard Henderson |
Subject: |
[PULL 7/8] accel/tcg: only USE_STATIC_CODE_GEN_BUFFER on 32 bit hosts |
Date: |
Fri, 28 Feb 2020 18:43:46 -0800 |
From: Alex Bennée <address@hidden>
There is no particular reason to use a static codegen buffer on 64 bit
hosts as we have address space to burn. Allow the common CONFIG_USER
case to use the mmap'ed buffers like SoftMMU.
Signed-off-by: Alex Bennée <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Niek Linnenbank <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
---
accel/tcg/translate-all.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c
index 5b66af783b..4ce5d1b393 100644
--- a/accel/tcg/translate-all.c
+++ b/accel/tcg/translate-all.c
@@ -892,11 +892,12 @@ static void page_lock_pair(PageDesc **ret_p1,
tb_page_addr_t phys1,
}
}
-#if defined(CONFIG_USER_ONLY)
-/* Currently it is not recommended to allocate big chunks of data in
- user mode. It will change when a dedicated libc will be used. */
-/* ??? 64-bit hosts ought to have no problem mmaping data outside the
- region in which the guest needs to run. Revisit this. */
+#if defined(CONFIG_USER_ONLY) && TCG_TARGET_REG_BITS == 32
+/*
+ * For user mode on smaller 32 bit systems we may run into trouble
+ * allocating big chunks of data in the right place. On these systems
+ * we utilise a static code generation buffer directly in the binary.
+ */
#define USE_STATIC_CODE_GEN_BUFFER
#endif
--
2.20.1
- [PULL 0/8] tcg patch queue, Richard Henderson, 2020/02/28
- [PULL 1/8] accel/tcg: fix race in cpu_exec_step_atomic (bug 1863025), Richard Henderson, 2020/02/28
- [PULL 6/8] accel/tcg: remove link between guest ram and TCG cache size, Richard Henderson, 2020/02/28
- [PULL 7/8] accel/tcg: only USE_STATIC_CODE_GEN_BUFFER on 32 bit hosts,
Richard Henderson <=
- [PULL 8/8] accel/tcg: increase default code gen buffer size for 64 bit, Richard Henderson, 2020/02/28
- [PULL 3/8] tcg/arm: Split out tcg_out_epilogue, Richard Henderson, 2020/02/28
- [PULL 5/8] accel/tcg: use units.h for defining code gen buffer sizes, Richard Henderson, 2020/02/28
- [PULL 2/8] compiler.h: Don't use compile-time assert when __NO_INLINE__ is defined, Richard Henderson, 2020/02/28
- [PULL 4/8] tcg/arm: Expand epilogue inline, Richard Henderson, 2020/02/28