qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 14/18] docs/system: Convert qemu-cpu-models.texi to rST


From: Paolo Bonzini
Subject: Re: [PATCH 14/18] docs/system: Convert qemu-cpu-models.texi to rST
Date: Thu, 27 Feb 2020 14:16:22 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1

[Part of the comments are either obvious or relevant to Kashyap's
original patch, I'm replying to those that are more directly for me.]

On 27/02/20 13:10, Peter Maydell wrote:
>>  create mode 100644 docs/system/cpu-models-mips.rst.inc
>>  create mode 100644 docs/system/cpu-models-x86.rst.inc
>>  create mode 100644 docs/system/defs.rst.inc
>>  create mode 100644 docs/system/qemu-cpu-models.rst
>>  delete mode 100644 docs/system/qemu-cpu-models.texi
> Why don't we also delete cpu-models-x86.texi and
> cpu-models-mips.texi ?
> 

They are included in the main manual.

>>
>> +rst_prolog = '''
>> +.. include:: defs.rst.inc
>> +'''
>> +
> 
> Maybe we should do this in docs/conf.py where we update
> rst_epilog with the CONFDIR replacement ?

Yes, that makes sense.

> Doing the "put these replacements into a generic defs.rst.inc"
> would also be clearer in its own patch, I think.

Agreed.

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]