[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] qemu-img: free memory before re-assign
|
From: |
Max Reitz |
|
Subject: |
Re: [PATCH 2/2] qemu-img: free memory before re-assign |
|
Date: |
Wed, 26 Feb 2020 11:13:48 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 |
On 26.02.20 04:30, Pan Nengyuan wrote:
> collect_image_check() is called twice in img_check(), the filename/format
> will be alloced without free the original memory.
> It is not a big deal since the process will exit anyway, but seems like a
> clean code and it will remove the warning spotted by asan.
>
> Reported-by: Euler Robot <address@hidden>
> Signed-off-by: Pan Nengyuan <address@hidden>
> ---
> qemu-img.c | 2 ++
> 1 file changed, 2 insertions(+)
I think this should happen in the caller. And there I think it would
make more sense to completely discard the old object and allocate a new one:
qapi_free_ImageCheck(check);
check = g_new0(ImageCheck, 1);
This way, we can’t forget to free any fields if new pointers were to be
added to the ImageCheck object.
Max
signature.asc
Description: OpenPGP digital signature