Re: [PULL 00/32] virtio, pc: fixes, features

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PULL 00/32] virtio, pc: fixes, features
Message-id: address@hidden
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
1c37a27 Fixed assert in vhost_user_set_mem_table_postcopy
bed1571 virtiofsd: add it to the tools list
9295d98 tests/vhost-user-bridge: move to contrib/
218b70f vhost-user: only set slave channel for first vq
5351c9b acpi: cpuhp: document CPHP_GET_CPU_ID_CMD command
082b014 libvhost-user: implement in-band notifications
84760e4 docs: vhost-user: add in-band kick/call messages
314ca4f libvhost-user: handle NOFD flag in call/kick/err better
57e2969 libvhost-user-glib: use g_main_context_get_thread_default()
2e9a28a libvhost-user-glib: fix VugDev main fd cleanup
abeaf81 libvhost-user: implement VHOST_USER_PROTOCOL_F_REPLY_ACK
b2dcd9c MAINTAINERS: add virtio-iommu related files
c2b7c49 hw/arm/virt: Add the virtio-iommu device tree mappings
e7d8ad0 virtio-iommu-pci: Add virtio iommu pci support
13a909a virtio-iommu: Support migration
3bc77b7 virtio-iommu: Implement fault reporting
4f6df8c virtio-iommu: Implement translate
eb6ee62 virtio-iommu: Implement map/unmap
c0d89aa virtio-iommu: Implement attach/detach command
30de952 virtio-iommu: Decode the command payload
faa62bf virtio-iommu: Add skeleton
1a2cc03 virtio: gracefully handle invalid region caches
a9d2299 vhost-user-blk: convert to new virtio_delete_queue
f5dba2c vhost-user-blk: delete virtioqueues in unrealize to fix memleaks
b022556 virtio-crypto: do delete ctrl_vq in virtio_crypto_device_unrealize
b7586a0 virtio-pmem: do delete rq_vq in virtio_pmem_unrealize
3d33901 vhost-user-fs: convert to the new virtio_delete_queue function
fc938b8 vhost-user-fs: do delete virtio_queues in unrealize
24dee37 rebuild-expected-aml.sh: remind about the process
908d585 bios-tables-test: default diff command
6047460 bios-tables-test: fix up DIFF generation
98eabca bios-tables-test: tell people how to update

=== OUTPUT BEGIN ===
1/32 Checking commit 98eabca21985 (bios-tables-test: tell people how to update)
2/32 Checking commit 60474600983e (bios-tables-test: fix up DIFF generation)
3/32 Checking commit 908d58520019 (bios-tables-test: default diff command)
WARNING: line over 80 characters
#30: FILE: tests/qtest/bios-tables-test.c:471:
+                                                 exp_sdt->asl_file, 
sdt->asl_file);

total: 0 errors, 1 warnings, 36 lines checked

Patch 3/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/32 Checking commit 24dee376fa13 (rebuild-expected-aml.sh: remind about the 
process)
ERROR: line over 90 characters
#22: FILE: tests/data/acpi/rebuild-expected-aml.sh:34:
+old_allowed_dif=`grep -v -e 'List of comma-separated changed AML files to 
ignore' ${SRC_PATH}/tests/qtest/bios-tables-test-allowed-diff.h`

ERROR: line over 90 characters
#30: FILE: tests/data/acpi/rebuild-expected-aml.sh:42:
+    echo "Note! Please follow the process documented in 
${SRC_PATH}/tests/qtest/bios-tables-test.c"

total: 2 errors, 0 warnings, 13 lines checked

Patch 4/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

5/32 Checking commit fc938b8bf16f (vhost-user-fs: do delete virtio_queues in 
unrealize)
6/32 Checking commit 3d3390160abf (vhost-user-fs: convert to the new 
virtio_delete_queue function)
WARNING: line over 80 characters
#26: FILE: hw/virtio/vhost-user-fs.c:212:
+    fs->hiprio_vq = virtio_add_queue(vdev, fs->conf.queue_size, 
vuf_handle_output);

WARNING: line over 80 characters
#32: FILE: hw/virtio/vhost-user-fs.c:217:
+        fs->req_vqs[i] = virtio_add_queue(vdev, fs->conf.queue_size, 
vuf_handle_output);

total: 0 errors, 2 warnings, 48 lines checked

Patch 6/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/32 Checking commit b7586a03bd40 (virtio-pmem: do delete rq_vq in 
virtio_pmem_unrealize)
8/32 Checking commit b02255628ccc (virtio-crypto: do delete ctrl_vq in 
virtio_crypto_device_unrealize)
9/32 Checking commit f5dba2cc1755 (vhost-user-blk: delete virtioqueues in 
unrealize to fix memleaks)
10/32 Checking commit a9d229943363 (vhost-user-blk: convert to new 
virtio_delete_queue)
11/32 Checking commit 1a2cc0393dac (virtio: gracefully handle invalid region 
caches)
12/32 Checking commit faa62bf0efdb (virtio-iommu: Add skeleton)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#62: 
new file mode 100644

total: 0 errors, 1 warnings, 350 lines checked

Patch 12/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
13/32 Checking commit 30de952a0895 (virtio-iommu: Decode the command payload)
14/32 Checking commit c0d89aa21d9c (virtio-iommu: Implement attach/detach 
command)
ERROR: spaces required around that '&' (ctx:WxV)
#134: FILE: hw/virtio/virtio-iommu.c:100:
+            return &dev->iommu_mr;
                    ^

ERROR: spaces required around that '-' (ctx:WxV)
#146: FILE: hw/virtio/virtio-iommu.c:112:
+        return -1;
                ^

ERROR: spaces required around that '&' (ctx:WxV)
#263: FILE: hw/virtio/virtio-iommu.c:229:
+    return &sdev->as;
            ^

total: 3 errors, 0 warnings, 419 lines checked

Patch 14/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

15/32 Checking commit eb6ee62eee5d (virtio-iommu: Implement map/unmap)
16/32 Checking commit 4f6df8cc7537 (virtio-iommu: Implement translate)
17/32 Checking commit 3bc77b78bf54 (virtio-iommu: Implement fault reporting)
18/32 Checking commit 13a909a3c904 (virtio-iommu: Support migration)
19/32 Checking commit e7d8ad08ff28 (virtio-iommu-pci: Add virtio iommu pci 
support)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#39: 
new file mode 100644

total: 0 errors, 1 warnings, 132 lines checked

Patch 19/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
20/32 Checking commit c2b7c4924eaa (hw/arm/virt: Add the virtio-iommu device 
tree mappings)
21/32 Checking commit b2dcd9c7ccf9 (MAINTAINERS: add virtio-iommu related files)
22/32 Checking commit abeaf81bc440 (libvhost-user: implement 
VHOST_USER_PROTOCOL_F_REPLY_ACK)
23/32 Checking commit 2e9a28ae1018 (libvhost-user-glib: fix VugDev main fd 
cleanup)
24/32 Checking commit 57e296958348 (libvhost-user-glib: use 
g_main_context_get_thread_default())
25/32 Checking commit 314ca4f7dde3 (libvhost-user: handle NOFD flag in 
call/kick/err better)
26/32 Checking commit 84760e4bbd49 (docs: vhost-user: add in-band kick/call 
messages)
27/32 Checking commit 082b014fe8a4 (libvhost-user: implement in-band 
notifications)
28/32 Checking commit 5351c9b649f9 (acpi: cpuhp: document CPHP_GET_CPU_ID_CMD 
command)
29/32 Checking commit 218b70f95e56 (vhost-user: only set slave channel for 
first vq)
30/32 Checking commit 9295d98bb196 (tests/vhost-user-bridge: move to contrib/)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#71: 
new file mode 100644

total: 0 errors, 1 warnings, 47 lines checked

Patch 30/32 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
31/32 Checking commit bed15711c0e9 (virtiofsd: add it to the tools list)
32/32 Checking commit 1c37a2773ed1 (Fixed assert in 
vhost_user_set_mem_table_postcopy)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden