qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 fixed 10/16] util/mmap-alloc: Factor out populating of mem


From: David Hildenbrand
Subject: Re: [PATCH v2 fixed 10/16] util/mmap-alloc: Factor out populating of memory to mmap_populate()
Date: Mon, 24 Feb 2020 11:54:18 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0

On 19.02.20 23:49, Peter Xu wrote:
> On Wed, Feb 12, 2020 at 02:42:48PM +0100, David Hildenbrand wrote:
>> We want to populate memory within a reserved memory region. Let's factor
>> that out.
>>
>> Reviewed-by: Richard Henderson <address@hidden>
>> Acked-by: Murilo Opsfelder Araujo <address@hidden>
>> Cc: Igor Kotrasinski <address@hidden>
>> Cc: "Michael S. Tsirkin" <address@hidden>
>> Cc: Greg Kurz <address@hidden>
>> Cc: Murilo Opsfelder Araujo <address@hidden>
>> Cc: Eduardo Habkost <address@hidden>
>> Cc: "Dr. David Alan Gilbert" <address@hidden>
>> Cc: Igor Mammedov <address@hidden>
>> Signed-off-by: David Hildenbrand <address@hidden>
> 
> The naming could be a bit misleading IMO, because we didn't populate
> the memory and it's still serviced on demand.  However I don't have a
> quick and better name of that either...

Right, depends I would say. With enable_mlock it would get serviced
right away. I also didn't find a better matching name ...

Thanks!

> 
> Reviewed-by: Peter Xu <address@hidden>
> 
-- 
Thanks,

David / dhildenb




reply via email to

[Prev in Thread] Current Thread [Next in Thread]