[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] target: i386: Check float overflow about register stack
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [PATCH] target: i386: Check float overflow about register stack |
|
Date: |
Fri, 21 Feb 2020 17:18:15 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 |
On 21/02/20 15:09, Chen Gang wrote:
>> - /* XXX: test fptags too */
>> + if (env->fptags[env->fpstt]) {
>> + env->fpus |= 0x4100; /* Empty */
>> + return;
>> + }
>> +
> For fpop overflow, this fix is enough, but for me, we still need
> foverflow to check fpush/fld*_ST0 overflow.
>
> Don't you think we need check fpush/f[i]ld*_ST0 overflow?
After fld/fild or any other push, FXAM ST0 should not return empty in my
opinion.
Paolo
- [PATCH] target: i386: Check float overflow about register stack, chengang, 2020/02/20
- Re: [PATCH] target: i386: Check float overflow about register stack, Paolo Bonzini, 2020/02/21
- Re: [PATCH] target: i386: Check float overflow about register stack, Chen Gang, 2020/02/21
- Re: [PATCH] target: i386: Check float overflow about register stack,
Paolo Bonzini <=
- Re: [PATCH] target: i386: Check float overflow about register stack, Chen Gang, 2020/02/21
- Re: [PATCH] target: i386: Check float overflow about register stack, Chen Gang, 2020/02/21
- Re: [PATCH] target: i386: Check float overflow about register stack, Paolo Bonzini, 2020/02/22
- Re: [PATCH] target: i386: Check float overflow about register stack, Chen Gang, 2020/02/22
- Re: [PATCH] target: i386: Check float overflow about register stack, Paolo Bonzini, 2020/02/24
- Re: [PATCH] target: i386: Check float overflow about register stack, Chen Gang, 2020/02/24