[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 5/5] aio-posix: make AioHandler dispatch O(1) with epoll
From: |
Stefan Hajnoczi |
Subject: |
Re: [PATCH 5/5] aio-posix: make AioHandler dispatch O(1) with epoll |
Date: |
Fri, 21 Feb 2020 15:29:02 +0000 |
On Fri, Feb 21, 2020 at 04:04:10PM +0100, Paolo Bonzini wrote:
> On 21/02/20 15:47, Stefan Hajnoczi wrote:
> >>> QLIST_SAFE_REMOVE(node, node_ready); /* remove from nested parent's
> >>> list */
> >>> ^---- would cause corruption if node->node_ready was stale!
> >>>
> >>> Would you like me to add a comment?
> >> No, it's okay.
> > Are you happy with this series?
>
> Yes. Let's keep the Q*_REMOVE cleanup on the todo list. I'd keep
> Q*_SAFE_REMOVE, but clear the pointer unconditionally in Q*_REMOVE so
> that we can have something like Q*_IN_LIST too.
QLIST_IS_INSERTED() is part of this patch series, although I can rename
it to Q*_IN_LIST() and cover all linked list variants. :)
> > Shall I include it in my next pull request or do you want to merge it?
>
> No, it's yours.
Thanks!
Stefan
signature.asc
Description: PGP signature
- [PATCH 3/5] qemu/queue.h: add QLIST_SAFE_REMOVE(), (continued)
- [PATCH 3/5] qemu/queue.h: add QLIST_SAFE_REMOVE(), Stefan Hajnoczi, 2020/02/14
- [PATCH 5/5] aio-posix: make AioHandler dispatch O(1) with epoll, Stefan Hajnoczi, 2020/02/14
- Re: [PATCH 5/5] aio-posix: make AioHandler dispatch O(1) with epoll, Sergio Lopez, 2020/02/19
- Re: [PATCH 5/5] aio-posix: make AioHandler dispatch O(1) with epoll, Paolo Bonzini, 2020/02/19
- Re: [PATCH 5/5] aio-posix: make AioHandler dispatch O(1) with epoll, Stefan Hajnoczi, 2020/02/21
- Re: [PATCH 5/5] aio-posix: make AioHandler dispatch O(1) with epoll, Paolo Bonzini, 2020/02/21
- Re: [PATCH 5/5] aio-posix: make AioHandler dispatch O(1) with epoll, Stefan Hajnoczi, 2020/02/21
- Re: [PATCH 5/5] aio-posix: make AioHandler dispatch O(1) with epoll, Stefan Hajnoczi, 2020/02/21
- Re: [PATCH 5/5] aio-posix: make AioHandler dispatch O(1) with epoll, Paolo Bonzini, 2020/02/21
- Re: [PATCH 5/5] aio-posix: make AioHandler dispatch O(1) with epoll,
Stefan Hajnoczi <=
- Re: [PATCH 5/5] aio-posix: make AioHandler dispatch O(1) with epoll, Paolo Bonzini, 2020/02/21
[PATCH 4/5] aio-posix: make AioHandler deletion O(1), Stefan Hajnoczi, 2020/02/14
Re: [PATCH 0/5] aio-posix: towards an O(1) event loop, Stefan Hajnoczi, 2020/02/21