[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 12/19] target/arm: Remove ARM_FEATURE_VFP check from disas_vf
From: |
Peter Maydell |
Subject: |
Re: [PATCH 12/19] target/arm: Remove ARM_FEATURE_VFP check from disas_vfp_insn |
Date: |
Thu, 20 Feb 2020 17:19:28 +0000 |
On Fri, 14 Feb 2020 at 18:16, Richard Henderson
<address@hidden> wrote:
>
> We now have proper ISA checks within each trans_* function.
>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
> target/arm/translate.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/target/arm/translate.c b/target/arm/translate.c
> index 0da780102c..e8c3d4f26f 100644
> --- a/target/arm/translate.c
> +++ b/target/arm/translate.c
> @@ -2652,10 +2652,6 @@ static void gen_neon_dup_high16(TCGv_i32 var)
> */
> static int disas_vfp_insn(DisasContext *s, uint32_t insn)
> {
> - if (!arm_dc_feature(s, ARM_FEATURE_VFP)) {
> - return 1;
> - }
> -
> /*
> * If the decodetree decoder handles this insn it will always
> * emit code to either execute the insn or generate an appropriate
> --
> 2.20.1
Reviewed-by: Peter Maydell <address@hidden>
thanks
-- PMM
- Re: [PATCH 06/19] target/arm: Rename isar_feature_aa32_fpdp_v2, (continued)
- [PATCH 04/19] target/arm: Set MVFR0.FPSP for ARMv5 cpus, Richard Henderson, 2020/02/14
- [PATCH 07/19] target/arm: Add isar_feature_aa32_{fpsp_v2, fpsp_v3, fpdp_v3}, Richard Henderson, 2020/02/14
- [PATCH 05/19] target/arm: Add isar_feature_aa32_simd_r16, Richard Henderson, 2020/02/14
- [PATCH 09/19] target/arm: Replace ARM_FEATURE_VFP3 checks with fp{sp, dp}_v3, Richard Henderson, 2020/02/14
- [PATCH 12/19] target/arm: Remove ARM_FEATURE_VFP check from disas_vfp_insn, Richard Henderson, 2020/02/14
- Re: [PATCH 12/19] target/arm: Remove ARM_FEATURE_VFP check from disas_vfp_insn,
Peter Maydell <=
- [PATCH 08/19] target/arm: Perform fpdp_v2 check first, Richard Henderson, 2020/02/14
- [PATCH 10/19] target/arm: Add missing checks for fpsp_v2, Richard Henderson, 2020/02/14
- [PATCH 11/19] target/arm: Replace ARM_FEATURE_VFP4 with isar_feature_aa32_simdfmac, Richard Henderson, 2020/02/14
- [PATCH 13/19] target/arm: Move VLLDM and VLSTM to vfp.decode, Richard Henderson, 2020/02/14