[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] rcu_queue: add QSLIST functions
From: |
no-reply |
Subject: |
Re: [PATCH] rcu_queue: add QSLIST functions |
Date: |
Thu, 20 Feb 2020 02:43:35 -0800 (PST) |
Patchew URL: https://patchew.org/QEMU/address@hidden/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PATCH] rcu_queue: add QSLIST functions
Message-id: address@hidden
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
- [tag update] patchew/address@hidden -> patchew/address@hidden
* [new tag] patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
909114b rcu_queue: add QSLIST functions
=== OUTPUT BEGIN ===
WARNING: Block comments use a leading /* on a separate line
#26: FILE: include/qemu/queue.h:217:
+} while (/*CONSTCOND*/0)
WARNING: Block comments use a leading /* on a separate line
#61: FILE: include/qemu/rcu_queue.h:278:
+} while (/*CONSTCOND*/0)
WARNING: Block comments use a leading /* on a separate line
#66: FILE: include/qemu/rcu_queue.h:283:
+} while (/*CONSTCOND*/0)
WARNING: Block comments use a leading /* on a separate line
#70: FILE: include/qemu/rcu_queue.h:287:
+} while (/*CONSTCOND*/0)
WARNING: Block comments use a leading /* on a separate line
#83: FILE: include/qemu/rcu_queue.h:300:
+} while (/*CONSTCOND*/0)
ERROR: code indent should never use tabs
#141: FILE: tests/test-rcu-list.c:155:
+^I QSLIST_REMOVE_RCU(&Q_list_head, el, list_element, f)$
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#153:
new file mode 100644
total: 1 errors, 6 warnings, 119 lines checked
Commit 909114b5ff89 (rcu_queue: add QSLIST functions) has style problems,
please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden