[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] pcie_root_port: Add disable_hotplug option
|
From: |
Michael S. Tsirkin |
|
Subject: |
Re: [PATCH] pcie_root_port: Add disable_hotplug option |
|
Date: |
Tue, 18 Feb 2020 22:47:05 -0500 |
On Tue, Feb 18, 2020 at 10:02:19PM -0500, Laine Stump wrote:
> Also, is there a rhyme/reason for some options having true/false, and some
> being off/on? disable-acs seems to be true/false, but disable-modern is
> on/off. Doesn't make any difference to me in the end, but just thought I'd
> bring it up in case there might be a reason to use on/off instead of
> true/false for this one.
Some places accept on/off, some true/false, some on/off/true/false
others on/off/yes/no and others on/off/true/false/yes/no.
In this case both user visitor machinery. Which I *think*
means on/off is the safe choice and true/false can be
broken in some places.
We really should clean up this mess ... Julia, what do you think?
Let's make them all support all options?
--
MST
Re: [PATCH] pcie_root_port: Add disable_hotplug option, Daniel P . Berrangé, 2020/02/21
Re: [PATCH] pcie_root_port: Add disable_hotplug option, Ján Tomko, 2020/02/18