Re: [PATCH] Avoid address_space_rw() with a constant is_write argument

[Peter Maydell]

On Tue, 18 Feb 2020 at 11:19, Paolo Bonzini <address@hidden> wrote:
>
> On 18/02/20 12:01, Peter Maydell wrote:
> > I could break this down into separate patches by submaintainer,
> > but the patch is not that large and I would argue that it's
> > better for the project if we can try to avoid introducing too
> > much friction into the process of doing 'safe' tree-wide
> > minor refactorings.
> > ---
> >  accel/kvm/kvm-all.c       |  6 ++--
> >  dma-helpers.c             |  4 +--
> >  exec.c                    |  4 +--
> >  hw/dma/xlnx-zdma.c        | 11 +++----
> >  hw/net/dp8393x.c          | 68 ++++++++++++++++++++-------------------
> >  hw/net/i82596.c           | 25 +++++++-------
> >  hw/net/lasi_i82596.c      |  5 +--
> >  hw/ppc/pnv_lpc.c          |  8 ++---
> >  hw/s390x/css.c            | 12 +++----
> >  qtest.c                   | 52 +++++++++++++++---------------
> >  target/i386/hvf/x86_mmu.c | 12 +++----
> >  11 files changed, 103 insertions(+), 104 deletions(-)
>
> I agree, but please include the semantic patch in scripts/coccinelle/.

I'd forgotten we had that. v2 sent.

-- PMM