Re: [RFC qemu 0/6] mirror: implement incremental and bitmap modes

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [RFC qemu 0/6] mirror: implement incremental and bitmap modes
Message-id: address@hidden
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
50da7dd mirror: move some checks to QMP
2236985 iotests: add test for bitmap mirror
b65aa31 mirror: switch to bdrv_dirty_bitmap_merge_internal
c03e05f mirror: add check for bitmap-mode without bitmap
1e909f2 drive-mirror: add support for conditional and always bitmap sync modes
e7baad3 drive-mirror: add support for sync=bitmap mode=never

=== OUTPUT BEGIN ===
1/6 Checking commit e7baad3a765b (drive-mirror: add support for sync=bitmap 
mode=never)
2/6 Checking commit 1e909f289147 (drive-mirror: add support for conditional and 
always bitmap sync modes)
ERROR: Missing Signed-off-by: line(s)

total: 1 errors, 0 warnings, 48 lines checked

Patch 2/6 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/6 Checking commit c03e05f9f733 (mirror: add check for bitmap-mode without 
bitmap)
4/6 Checking commit b65aa312e64e (mirror: switch to 
bdrv_dirty_bitmap_merge_internal)
5/6 Checking commit 2236985625be (iotests: add test for bitmap mirror)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#24: 
new file mode 100755

total: 0 errors, 1 warnings, 3397 lines checked

Patch 5/6 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/6 Checking commit 50da7ddd187c (mirror: move some checks to QMP)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden