qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 41/79] hppa: use memdev for RAM


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v5 41/79] hppa: use memdev for RAM
Date: Tue, 18 Feb 2020 08:00:21 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1

On 2/17/20 6:34 PM, Igor Mammedov wrote:
memory_region_allocate_system_memory() API is going away, so
replace it with memdev allocated MemoryRegion. The later is
initialized by generic code, so board only needs to opt in
to memdev scheme by providing
   MachineClass::default_ram_id
and using MachineState::ram instead of manually initializing
RAM memory region.

Signed-off-by: Igor Mammedov <address@hidden>
---
CC: address@hidden
CC: address@hidden
---
  hw/hppa/machine.c | 10 +++-------
  1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/hw/hppa/machine.c b/hw/hppa/machine.c
index d8755ec422..67181e75ba 100644
--- a/hw/hppa/machine.c
+++ b/hw/hppa/machine.c
@@ -71,14 +71,11 @@ static void machine_hppa_init(MachineState *machine)
      uint64_t kernel_entry = 0, kernel_low, kernel_high;
      MemoryRegion *addr_space = get_system_memory();
      MemoryRegion *rom_region;
-    MemoryRegion *ram_region;
      MemoryRegion *cpu_region;
      long i;
      unsigned int smp_cpus = machine->smp.cpus;
      SysBusDevice *s;
- ram_size = machine->ram_size;
-
      /* Create CPUs.  */
      for (i = 0; i < smp_cpus; i++) {
          char *name = g_strdup_printf("cpu%ld-io-eir", i);
@@ -97,10 +94,8 @@ static void machine_hppa_init(MachineState *machine)
          error_report("RAM size is currently restricted to 3GB");
          exit(EXIT_FAILURE);
      }
-    ram_region = g_new(MemoryRegion, 1);
-    memory_region_allocate_system_memory(ram_region, OBJECT(machine),
-                                         "ram", ram_size);
-    memory_region_add_subregion_overlap(addr_space, 0, ram_region, -1);
+    memory_region_add_subregion_overlap(addr_space, 0, machine->ram, -1);
+
/* Init Lasi chip */
      lasi_init(addr_space);
@@ -298,6 +293,7 @@ static void machine_hppa_machine_init(MachineClass *mc)
      mc->is_default = 1;
      mc->default_ram_size = 512 * MiB;
      mc->default_boot_order = "cd";
+    mc->default_ram_id = "ram";
  }
DEFINE_MACHINE("hppa", machine_hppa_machine_init)


Reviewed-by: Philippe Mathieu-Daudé <address@hidden>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]