[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3] configure: Avoid compiling system tools on user build by
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v3] configure: Avoid compiling system tools on user build by default |
Date: |
Mon, 17 Feb 2020 14:34:37 +0100 |
On Mon, Feb 17, 2020 at 2:33 PM Philippe Mathieu-Daudé <address@hidden> wrote:
>
> User-mode does not need the system tools. Do not build them by
> default if the user specifies --disable-system.
>
> This disables building the following binaries on a user-only build:
>
> - elf2dmp
> - qemu-edid
> - qemu-ga
> - qemu-img
> - qemu-io
> - qemu-nbd
> - ivshmem-client
> - ivshmem-server
>
> The qemu-user binaries are not affected by this change.
>
I forgot to add:
Reviewed-by: Laurent Vivier <address@hidden>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> v3:
> - fixed typos (Aleksandar)
> v2:
> - use simpler if/else statement (therefore not adding Richard R-b)
> - improved description (Aleksandar)
> ---
> configure | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 6f5d850949..efe00dd497 100755
> --- a/configure
> +++ b/configure
> @@ -455,7 +455,7 @@ guest_agent_ntddscsi="no"
> guest_agent_msi=""
> vss_win32_sdk=""
> win_sdk="no"
> -want_tools="yes"
> +want_tools=""
> libiscsi=""
> libnfs=""
> coroutine=""
> @@ -2213,6 +2213,16 @@ else
> echo big/little test failed
> fi
>
> +##########################################
> +# system tools
> +if test -z "$want_tools"; then
> + if test "$softmmu" = "no"; then
> + want_tools=no
> + else
> + want_tools=yes
> + fi
> +fi
> +
> ##########################################
> # cocoa implies not SDL or GTK
> # (the cocoa UI code currently assumes it is always the active UI
> --
> 2.21.1
>