Re: [PATCH v2 1/3] tools/virtiofsd/passthrough_ll: Remove unneeded variable assignment

[Dr. David Alan Gilbert]

* Philippe Mathieu-Daudé (address@hidden) wrote:
> Fix warning reported by Clang static code analyzer:
> 
>     CC      tools/virtiofsd/passthrough_ll.o
>   tools/virtiofsd/passthrough_ll.c:1083:5: warning: Value stored to 'saverr' 
> is never read
>       saverr = ENOMEM;
>       ^        ~~~~~~
> 
> Fixes: 7c6b66027
> Reported-by: Clang Static Analyzer
> Reviewed-by: Ján Tomko <address@hidden>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>

Thanks, you might want to snd that to the upstream libfuse
(different context); it looks like it's the same there.


Reviewed-by: Dr. David Alan Gilbert <address@hidden>

Dave

> ---
>  tools/virtiofsd/passthrough_ll.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/tools/virtiofsd/passthrough_ll.c 
> b/tools/virtiofsd/passthrough_ll.c
> index c635fc8820..e9e71d5fc2 100644
> --- a/tools/virtiofsd/passthrough_ll.c
> +++ b/tools/virtiofsd/passthrough_ll.c
> @@ -1080,8 +1080,6 @@ static void lo_mknod_symlink(fuse_req_t req, fuse_ino_t 
> parent,
>          return;
>      }
>  
> -    saverr = ENOMEM;
> -
>      saverr = lo_change_cred(req, &old);
>      if (saverr) {
>          goto out;
> -- 
> 2.21.1
> 
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK