qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 1/2] tcg/arm: Split out tcg_out_epilogue


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v2 1/2] tcg/arm: Split out tcg_out_epilogue
Date: Mon, 17 Feb 2020 10:47:16 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1

On 2/16/20 10:41 AM, Richard Henderson wrote:
From: Richard Henderson <address@hidden>

We will shortly use this function from tcg_out_op as well.

Signed-off-by: Richard Henderson <address@hidden>
---
  tcg/arm/tcg-target.inc.c | 19 +++++++++++--------
  1 file changed, 11 insertions(+), 8 deletions(-)

diff --git a/tcg/arm/tcg-target.inc.c b/tcg/arm/tcg-target.inc.c
index fffb6611e2..e1aa740ba4 100644
--- a/tcg/arm/tcg-target.inc.c
+++ b/tcg/arm/tcg-target.inc.c
@@ -1746,6 +1746,7 @@ static void tcg_out_qemu_st(TCGContext *s, const TCGArg 
*args, bool is64)
  }
static tcg_insn_unit *tb_ret_addr;
+static void tcg_out_epilogue(TCGContext *s);
static inline void tcg_out_op(TCGContext *s, TCGOpcode opc,
                  const TCGArg *args, const int *const_args)
@@ -2284,19 +2285,17 @@ static void tcg_out_nop_fill(tcg_insn_unit *p, int 
count)
        + TCG_TARGET_STACK_ALIGN - 1) \
       & -TCG_TARGET_STACK_ALIGN)
+#define STACK_ADDEND (FRAME_SIZE - PUSH_SIZE)
+
  static void tcg_target_qemu_prologue(TCGContext *s)
  {
-    int stack_addend;
-
      /* Calling convention requires us to save r4-r11 and lr.  */
      /* stmdb sp!, { r4 - r11, lr } */
      tcg_out32(s, (COND_AL << 28) | 0x092d4ff0);
/* Reserve callee argument and tcg temp space. */
-    stack_addend = FRAME_SIZE - PUSH_SIZE;
-
      tcg_out_dat_rI(s, COND_AL, ARITH_SUB, TCG_REG_CALL_STACK,
-                   TCG_REG_CALL_STACK, stack_addend, 1);
+                   TCG_REG_CALL_STACK, STACK_ADDEND, 1);
      tcg_set_frame(s, TCG_REG_CALL_STACK, TCG_STATIC_CALL_ARGS_SIZE,
                    CPU_TEMP_BUF_NLONGS * sizeof(long));
@@ -2310,11 +2309,15 @@ static void tcg_target_qemu_prologue(TCGContext *s)
       */
      s->code_gen_epilogue = s->code_ptr;
      tcg_out_movi(s, TCG_TYPE_PTR, TCG_REG_R0, 0);
-
-    /* TB epilogue */
      tb_ret_addr = s->code_ptr;
+    tcg_out_epilogue(s);
+}
+
+static void tcg_out_epilogue(TCGContext *s)
+{
+    /* Release local stack frame.  */
      tcg_out_dat_rI(s, COND_AL, ARITH_ADD, TCG_REG_CALL_STACK,
-                   TCG_REG_CALL_STACK, stack_addend, 1);
+                   TCG_REG_CALL_STACK, STACK_ADDEND, 1);
/* ldmia sp!, { r4 - r11, pc } */
      tcg_out32(s, (COND_AL << 28) | 0x08bd8ff0);


Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

Thanks for splitting v1 :)




reply via email to

[Prev in Thread] Current Thread [Next in Thread]