qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3] Implement the Screamer sound chip for the mac99 machine t


From: Howard Spoelstra
Subject: Re: [PATCH v3] Implement the Screamer sound chip for the mac99 machine type
Date: Mon, 17 Feb 2020 08:17:20 +0100



Hi Howard, could you test out this patch for me on Fedora 31? It is to be applied over the v3 patch.

Thank you.

---
 hw/audio/screamer.c | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/hw/audio/screamer.c b/hw/audio/screamer.c
index ad4aba12eb..7de17fe8a6 100644
--- a/hw/audio/screamer.c
+++ b/hw/audio/screamer.c
@@ -14,7 +14,7 @@
 #include "migration/vmstate.h"
 #include "include/hw/audio/screamer.h"

-#define DEBUG_SCREAMER 0
+#define DEBUG_SCREAMER 1
 #define DPRINTF(fmt, ...) \
 do { if (DEBUG_SCREAMER) { printf(fmt , ## __VA_ARGS__); } } while (0)

@@ -836,11 +836,12 @@ static uint64_t screamer_mmio_read(void *opaque, hwaddr addr, unsigned size)
         return_value = get_frame_count_reg(state);
         break;
     default:
-        DPRINTF("Unknown register read - addr:%llu\tsize:%d\n", addr, size);
+        DPRINTF("Unknown register read - addr:%" HWADDR_PRIx "\tsize:%d\n",
+                addr, size);
         return_value = 12021981; /* Value used for debugging purposes */
     }
-    DPRINTF("screamer_mmio_read() called addr: %llu  size: %d", addr >> 4,
-            size);
+    DPRINTF("screamer_mmio_read() called addr: %" HWADDR_PRIx "  size: %d",
+            addr >> 4, size);
     DPRINTF("  returning 0x%x\n", return_value);
     return return_value;
 }
@@ -875,7 +876,8 @@ static void screamer_mmio_write(void *opaque, hwaddr addr, uint64_t raw_value,
         set_frame_count_reg(state, value);
         break;
     default:
-        DPRINTF("Unknown register write - addr:%llu\tvalue:%d\n", addr, value);
+        DPRINTF("Unknown register write - addr:%" HWADDR_PRIx "\tvalue:%d\n",
+                addr, value);
     }
 }



Tested, compiles cleanly. Debug output seems OK.

Best,
Howard

reply via email to

[Prev in Thread] Current Thread [Next in Thread]