Re: [PATCH 6/7] commit: Expose on-error option in QMP

[Ján Tomko]

On Fri, Feb 14, 2020 at 09:08:11PM +0100, Kevin Wolf wrote:
> Now that the error handling in the common block job is fixed, we can
> expose the on-error option in QMP instead of hard-coding it as 'report'
> in qmp_block_commit().
>
> This fulfills the promise that the old comment in that function made,
> even if a bit later than expected: "This will be part of the QMP
> command, if/when the BlockdevOnError change for blkmirror makes it in".
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> qapi/block-core.json | 4 ++++
> blockdev.c           | 8 ++++----
> 2 files changed, 8 insertions(+), 4 deletions(-)

Reviewed-by: Ján Tomko <address@hidden>

Jano

signature.asc
Description: PGP signature